Skip to content

Comments

add explicit permissions for ESO resources#781

Merged
SgtCoDFish merged 1 commit intomasterfrom
eso-permissions
Feb 24, 2026
Merged

add explicit permissions for ESO resources#781
SgtCoDFish merged 1 commit intomasterfrom
eso-permissions

Conversation

@SgtCoDFish
Copy link
Contributor

@SgtCoDFish SgtCoDFish commented Feb 24, 2026

I was seeing issues in e2e tests in a separate PR with permissions for ESO resources. I'd thought that the way ESO was configured with the viewer role would mean the permissions were fine, but maybe it's best to be explicit anyway.

This was caught in a copilot review on #780 but I really thought it wouldn't be a problem.

I was seeing issues in e2e tests in a separate PR with
permissions for ESO resources. I'd thought that the
way ESO was configured with the viewer role would mean
the permissions were fine, but maybe it's best to be
explicit anyway

Signed-off-by: Ashley Davis <ashley.davis@cyberark.com>
Copy link
Member

@wallrj-cyberark wallrj-cyberark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I can see the watcher / lister starting up successfully, in the E2E test logs:

{
  "ts": 1771946690636.7156,
  "caller": "transport/round_trippers.go:632",
  "msg": "Response",
  "v": 6,
  "verb": "GET",
  "url": "[https://10.96.0.1:443/apis/external-secrets.io/v1/secretstores?limit=500&resourceVersion=0](https://10.96.0.1/apis/external-secrets.io/v1/secretstores?limit=500&resourceVersion=0)",
  "status": "200 OK",
  "milliseconds": 4
}

In comparison to the previous PR, where the logs show the request is forbidden:

{
  "ts": 1771856354155.9285,
  "caller": "transport/round_trippers.go:632",
  "msg": "Response",
  "v": 6,
  "verb": "GET",
  "url": "[https://10.96.0.1:443/apis/external-secrets.io/v1/clusterexternalsecrets?limit=500&resourceVersion=0](https://10.96.0.1/apis/external-secrets.io/v1/clusterexternalsecrets?limit=500&resourceVersion=0)",
  "status": "403 Forbidden",
  "milliseconds": 2
}
{
  "ts": 1771856354155.96,
  "caller": "transport/round_trippers.go:632",
  "msg": "Response",
  "v": 6,
  "verb": "GET",
  "url": "[https://10.96.0.1:443/apis/external-secrets.io/v1/secretstores?limit=500&resourceVersion=0](https://10.96.0.1/apis/external-secrets.io/v1/secretstores?limit=500&resourceVersion=0)",
  "status": "200 OK",
  "milliseconds": 2
}

@SgtCoDFish SgtCoDFish merged commit d9a7b26 into master Feb 24, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants