Skip to content

fix(k8s): retain conjur-map key in SecretSelectedFields and tests #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wallrj-cyberark merged 1 commit into from
Sep 11, 2025
Merged

fix(k8s): retain conjur-map key in SecretSelectedFields and tests #712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/datagatherers/k8s-dynamic.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ Secrets can be gathered using the following config:
resource: secrets
```

Before Secrets are sent to the Preflight backend, they are redacted so no secret data is transmitted. See [`fieldfilter.go`](./../../pkg/datagatherer/k8s/fieldfilter.go) to see the details of which fields are filteres and which ones are redacted.
Before Secrets are sent to the Preflight backend, they are redacted so no secret data is transmitted. See [`fieldfilter.go`](./../../pkg/datagatherer/k8s/fieldfilter.go) to see the details of which fields are filtered and which ones are redacted.

> **All resource other than Kubernetes Secrets are sent in full, so make sure that you don't store secret information on arbitrary resources.**

Expand Down
4 changes: 4 additions & 0 deletions pkg/datagatherer/k8s/fieldfilter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ import (
// The `data` is redacted, to prevent private keys or sensitive data being
// collected. Only the following none-sensitive keys are retained: tls.crt,
// ca.crt. These keys are assumed to always contain public TLS certificates.
// The `conjur-map` key is also retained, as it is used to map Secrets to
// Conjur variables, and is not considered sensitive.
// See https://docs.cyberark.com/conjur-open-source/latest/en/content/integrations/k8s-ocp/cjr-secrets-provider-lp.htm
var SecretSelectedFields = []FieldPath{
{"kind"},
{"apiVersion"},
Expand All @@ -26,6 +29,7 @@ var SecretSelectedFields = []FieldPath{
{"type"},
{"data", "tls.crt"},
{"data", "ca.crt"},
{"data", "conjur-map"},
}

// RouteSelectedFields is the list of fields sent from OpenShift Route objects to the
Expand Down
9 changes: 6 additions & 3 deletions pkg/datagatherer/k8s/fieldfilter_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,10 @@ func TestSelect(t *testing.T) {
},
"type": "kubernetes.io/tls",
"data": map[string]interface{}{
"tls.crt": "cert data",
"tls.key": "secret",
"tls.crt": "cert data",
"tls.key": "secret",
"extra": "should be removed",
"conjur-map": "should be kept",
},
},
SecretSelectedFields,
Expand All @@ -61,7 +63,8 @@ func TestSelect(t *testing.T) {
"type": "kubernetes.io/tls",
"data": map[string]interface{}{
// The "tls.key" is ignored.
"tls.crt": "cert data",
"tls.crt": "cert data",
"conjur-map": "should be kept",
},
},
))
Expand Down