VC-39644 Collect info for the venafiConnection and more issuers#648
Merged
Conversation
j-fuentes
approved these changes
Apr 30, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR extends the Kubernetes agent's resource collection capabilities to support additional issuers and the Venafi connection.
- Adds new RBAC definitions for Venafi Connection, Smallstep Issuer, Cloudflare Origin CA, FreeIPA Issuer, and EJBCA Issuer.
- Updates the configuration map to include dynamic resource configurations for the newly supported resources.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| deploy/charts/venafi-kubernetes-agent/templates/rbac.yaml | New ClusterRoles and ClusterRoleBindings for managing access to the various resource types. |
| deploy/charts/venafi-kubernetes-agent/templates/configmap.yaml | Added k8s-dynamic resource definitions for Venafi Connection, Smallstep Issuer, Cloudflare Origin CA, FreeIPA Issuer, and EJBCA Issuer. |
Comments suppressed due to low confidence (2)
deploy/charts/venafi-kubernetes-agent/templates/rbac.yaml:433
- [nitpick] The name 'keyfactor-reader' might be confusing given that the group is 'ejbca-issuer.keyfactor.com'. Consider renaming it to 'ejbca-reader' for clarity, if that accurately reflects its purpose.
name: {{ include "venafi-kubernetes-agent.fullname" . }}-keyfactor-reader
deploy/charts/venafi-kubernetes-agent/templates/configmap.yaml:261
- [nitpick] Consider using a consistent naming convention by adding a hyphen (e.g., 'k8s/freeipa-issuers') to align with the naming patterns used for the other issuer resources.
name: "k8s/freeipaissuers"
Contributor
|
I ran the E2E test script (it has to be run manually for the time being. Everything seemed to work fine. Here's some of the output: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Kubernetes agent by extending its resource collection capabilities. The newly supported resources include: