Skip to content

fix: forward POST body and content-type header #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jergason merged 1 commit into from
Mar 23, 2026
Merged

fix: forward POST body and content-type header #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/proxy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,11 @@ export async function handleProxy(targetUrl: string, request: Request): Promise<

let targetResponse: Response;
try {
const hasBody = request.method !== "GET" && request.method !== "HEAD";
targetResponse = await fetch(targetUrl, {
method: request.method,
headers: forwardHeaders(request),
body: hasBody ? request.body : undefined,
redirect: "manual",
});
} catch {
Expand Down
16 changes: 16 additions & 0 deletions src/rewriter.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,4 +138,20 @@ describe("HTMLRewriter integration", () => {
const allProxied = dataSrcMatches.every((m) => m.includes("/browse/"));
expect(allProxied).toBe(true);
});

it("forwards POST body and content-type header", async () => {
const resp = await worker.fetch("/browse/https://httpbin.org/post", {
method: "POST",
headers: { "content-type": "application/x-www-form-urlencoded" },
body: "query=test&page=1",
});
if (resp.status !== 200) return;
Comment on lines +142 to +148
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test silently passes when httpbin is unavailable (if (resp.status !== 200) return;), which means CI can go green without actually validating POST body/header forwarding. Prefer making the test deterministic (mock the upstream / use a local stub), or at least mark it as explicitly skipped (e.g., Vitest it.runIf(...) / this.skip()) rather than returning early so the missing coverage is visible.

Copilot uses AI. Check for mistakes.
const data = (await resp.json()) as {
form: Record<string, string>;
headers: Record<string, string>;
};
expect(data.form.query).toBe("test");
expect(data.form.page).toBe("1");
expect(data.headers["Content-Type"]).toContain("application/x-www-form-urlencoded");
});
});
10 changes: 9 additions & 1 deletion src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,15 @@ export function stripHeaders(headers: Headers): Headers {

export function forwardHeaders(request: Request): HeadersInit {
const forwarded: Record<string, string> = {};
const pass = ["user-agent", "accept", "accept-language", "accept-encoding", "cookie", "referer"];
const pass = [
"user-agent",
"accept",
"accept-language",
"accept-encoding",
"cookie",
"referer",
"content-type",
];
pass.forEach((h) => {
const v = request.headers.get(h);
if (v) forwarded[h] = v;
Expand Down
Loading