Skip to content

avoid printing too long argument lists during FlowNode visualization#70

Closed
ArturHarasimiuk wants to merge 1 commit intojenkinsci:masterfrom
ArturHarasimiuk:master
Closed

avoid printing too long argument lists during FlowNode visualization#70
ArturHarasimiuk wants to merge 1 commit intojenkinsci:masterfrom
ArturHarasimiuk:master

Conversation

@ArturHarasimiuk
Copy link
Copy Markdown
Contributor

In some cases it is possible that node argument will be impossible to
wrap properly and is displayed as single line. In this case pipeline
steps view becomes hard to read because right most columns are moved
beyond the screen. this requires scrolling which is not so convenient.
Also status colum is outside of screen.

This change cuts arguments list to 80 characters which should be fine
for most of usages.

Signed-off-by: Artur Harasimiuk artur.harasimiuk@intel.com

In some cases it is possible that node argument will be impossible to
wrap properly and is displayed as single line. In this case pipeline
steps view becomes hard to read because right most columns are moved
beyond the screen. this requires scrolling which is not so convenient.
Also status colum is outside of screen.

This change cuts arguments list to 80 characters which should be fine
for most of usages.

Signed-off-by: Artur Harasimiuk <artur.harasimiuk@intel.com>
Copy link
Copy Markdown
Member

@svanoort svanoort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, but I'm afraid this isn't the right way to handle this -- this truncates all Strings and means we do not get the full String content.

If you wish to limit the amount displayed, that should be done in the UI (wrap could also be implemented there, as needed). That would be either Blue Ocean plugin or Stage View (or potentially in the Steps view within workflow-support visualization.table under the resources folder).

@ArturHarasimiuk
Copy link
Copy Markdown
Contributor Author

thanks for comment. I created new PR: jenkinsci/workflow-support-plugin#71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants