Closed
Conversation
prevent warning
same as master
Update changelog.md
Migrer PHPStan vers une dépendance Composer (edit jeedom#3110)
Correction des méthodes statiques et du nommage de classes (PHPStan lvl 1)
Suppression des arguments superflus dans les appels de méthodes (PHPStan lvl 1)
…HPStan git ls-remote --exit-code retourne 2 quand la branche n'existe pas, ce qui, combiné à bash -e, faisait échouer tout le step. Remplacement par une condition if/grep pour ne pas propager le code de sortie.
…nch-check Corriger l'échec du workflow PHPStan lors de la suppression de branche
…mixing-tags Fix/scenario self execute mixing tags
[CI] Update PHPStan baseline
fix display_name field (ui)
Bugfix translation
Mips2648
requested changes
Apr 18, 2026
Collaborator
Mips2648
left a comment
There was a problem hiding this comment.
Il faudrait rebase sur develop aussi stp
…d'intégration Le champ `type` envoyé par le client dans `setComponentOrder` était concaténé directement dans la requête SQL, sans aucune validation, contrairement aux autres champs contrôlés par is_numeric(). Un admin pouvait injecter du SQL arbitraire (testé : `DROP TABLE viewData` s'exécute réellement). - Whitelist stricte sur le champ `type` (cmd, eqLogic, scenario) - Remplacement de la concaténation SQL multi-statements par un prepared statement exécuté à chaque itération - Tests d'intégration couvrant l'endpoint via un sous-processus PHP authentifié comme admin (payload DROP, UNION, type inconnu, type manquant)
fix: prevent a possible SQL injection in setComponentOrder
Add healthcheck in the docker container
Clarified the usage of the #trigger_name# tag and its implications for object, equipment, or command name changes.
c14311a to
9a34d54
Compare
Contributor
Author
|
nouvelle PR #3276 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
add log in case of plugin error via the plugin autoloader, this is a great help for plugin developers :)
Suggested changelog entry
add log in case of plugin error via the plugin autoloader
Related issues/external references
Fixes #3017
Types of changes
PR checklist