Added the ability to disable broadcasting#17
Open
luisdalmolin wants to merge 1 commit intojarektkaczyk:masterfrom
Open
Added the ability to disable broadcasting#17luisdalmolin wants to merge 1 commit intojarektkaczyk:masterfrom
luisdalmolin wants to merge 1 commit intojarektkaczyk:masterfrom
Conversation
|
+1 deleting mine, this would be awesome to see merged |
This was referenced Dec 11, 2019
Author
|
@jarektkaczyk Any chance we could get this one merged? Is not a breaking change in any way and it would be really helpful |
|
just chiming in to say that here in march 2021, this would still be helpful to have. i'm getting a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Laravel has a new handy
broadcastWhenmethod (https://laravel.com/docs/5.8/broadcasting#broadcast-conditions), which lets you control if you really want to broadcast even you are implementing the interface.This PR implements this method and a config value, so you can disable broadcasting where you don't want.