Skip to content

Automatically determines the cgroup values to allow at the LXC level#3

Open
lcotonea wants to merge 2 commits intojammsen:mainfrom
lcotonea:devices_group
Open

Automatically determines the cgroup values to allow at the LXC level#3
lcotonea wants to merge 2 commits intojammsen:mainfrom
lcotonea:devices_group

Conversation

@lcotonea
Copy link

In my case, the cgroups values are differents. So this pull request is a purpose to automatically compute the right cgroup values

read -r -p "Enter gateway [$GW_TEMPLATE]: " GATEWAY
GATEWAY=${GATEWAY:-$GW_TEMPLATE}

ROOT_FS_LOCATION_TEMPLATE="local-zfs"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didnt you create for this code-change a different PR already?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. Mishandling. (again :) )

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update 2026-03: Please remove this version then, see comment below

@jammsen
Copy link
Owner

jammsen commented Jan 6, 2026

I can test this on the weekend.

@jammsen jammsen mentioned this pull request Jan 10, 2026
@eikaramba
Copy link

fyi i did test this myself and can confirm it worked. the only thing i needed to adapt was to change card0 to card1. also i am not using zfs thus i needed to change the filesystem to ROOT_FS_LOCATION_TEMPLATE="local-lvm"

you can see this in my fork over at https://github.com/eikaramba/proxmox-setup-scripts

--ostype ubuntu \
--password testing \
--rootfs local-zfs:160 \
--rootfs $ROOT_FS_LOCATION:160 \
Copy link
Owner

@jammsen jammsen Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update 2026-03: I would rather have 1 pr for 1 major change, can we remove this from this PR, because we have already 1 for this exact thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants