Update deployer to newer version#72
Closed
tshabatyn wants to merge 11 commits into
Closed
Conversation
added 11 commits
December 17, 2020 21:58
Collaborator
|
LGTM, happy to merge this in. What do you think @sprankhub? It excludes PHP 8+, but compatibility could be added in another PR (even if it's just adding it to the list of supported PHP versions) Fixes #75 |
sprankhub
requested changes
Dec 29, 2021
| - composer self-update | ||
| - php -r "copy('https://getcomposer.org/installer', 'composer-setup.php');" | ||
| - php -r "if (hash_file('sha384', 'composer-setup.php') === '756890a4488ce9024fc62c56153228907f1545c228516cbf63f885e036d37e9a59d27d63f46af1d4d07ee0f76181c7d3') { echo 'Installer verified'; } else { echo 'Installer corrupt'; unlink('composer-setup.php'); } echo PHP_EOL;" | ||
| - php composer-setup.php --version=1.10.19 |
Collaborator
There was a problem hiding this comment.
Suggested change
| - php composer-setup.php --version=1.10.19 | |
| - php composer-setup.php --1 |
Why do we fix this to a specific version? I suggest using at least the latest v1 version. Or can we even switch to v2?
Collaborator
There was a problem hiding this comment.
I've been using this with Composer 2 just fine, so it probably could do without a version
There was a problem hiding this comment.
Indeed, composer 2 is now supported on both 2.3 and 2.4, so I agree that there's no need to hardcore composer version to v1
Collaborator
|
Closing this one as I've created a newer PR which includes this one (#80) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old version of deployer throws the following error in the Docker container.