Update SQLAlchemy and Add uv support by jagatsingh · Pull Request #1 · jagatsingh/sqlalchemy-redshift

jagatsingh · 2025-09-05T21:51:19Z

Adds SQLAlechemy 2.x
Add uv support

- Add pyproject.toml with uv configuration and project metadata - Update CI buildspec to use uv instead of tox - Update README with uv installation and usage instructions - Maintain backward compatibility with existing tox workflow

Copilot

Pull Request Overview

This PR modernizes the sqlalchemy-redshift package by updating it for SQLAlchemy 2.x compatibility and adding uv package manager support. The changes include migrating from deprecated SQLAlchemy 1.x APIs to their 2.x equivalents, replacing setup.py with pyproject.toml configuration, and updating the development toolchain.

Key changes:

Updates SQLAlchemy API calls from 1.x to 2.x syntax (select statements, column access, imports)
Replaces tox with uv for dependency management and testing
Migrates from setup.py to pyproject.toml with modern Python packaging standards

Reviewed Changes

Copilot reviewed 35 out of 36 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
pyproject.toml	Modern packaging configuration replacing setup.py
sqlalchemy_redshift/dialect.py	Core dialect updates for SQLAlchemy 2.x compatibility
tests/*.py	Test updates for new SQLAlchemy 2.x syntax
ci/*.yml	CI pipeline updates for uv and Redshift Serverless
.github/workflows/*.yml	New GitHub Actions workflows for security, releases

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-05T21:52:48Z

sqlalchemy_redshift/dialect.py

+
+        In SQLAlchemy 2.0, the parent _get_column_info method was removed,
+        so we implement the logic directly.


The docstring has incomplete information about the method parameters. It should document all parameters including domains, enums, and **kwargs for API clarity.

Suggested change

In SQLAlchemy 2.0, the parent _get_column_info method was removed,

so we implement the logic directly.

In SQLAlchemy 2.0, the parent _get_column_info method was removed,

so we implement the logic directly.

Parameters

----------

name : str

The name of the column.

format_type : str

The PostgreSQL format type string for the column (e.g., 'varchar(30)', 'integer').

default : str or None

The default value for the column, if any.

notnull : bool

Whether the column is NOT NULL.

domains : dict

Domain information for the column, if any.

enums : dict

Enum information for the column, if any.

schema : str, optional

The schema name, if applicable.

encode : str, optional

Redshift-specific encoding for the column, if any.

comment : str, optional

Comment for the column, if any.

identity : dict, optional

Identity information for the column (SQLAlchemy 2.0+).

**kwargs

Additional keyword arguments.

Returns

-------

dict

A dictionary containing column information suitable for SQLAlchemy Table reflection.

Copilot · 2025-09-05T21:52:48Z

sqlalchemy_redshift/dialect.py

+                coltype = VARCHAR  # Use VARCHAR as default
+        except (KeyError, AttributeError):
+            coltype = VARCHAR  # fallback for unknown types


Using VARCHAR as a fallback for unknown types may not be appropriate for all Redshift data types. Consider using a more generic type like NullType or raising an informative error for unsupported types.

Suggested change

coltype = VARCHAR # Use VARCHAR as default

except (KeyError, AttributeError):

coltype = VARCHAR # fallback for unknown types

coltype = NullType # Use NullType as default for unknown types

except (KeyError, AttributeError):

coltype = NullType # fallback for unknown types

Copilot · 2025-09-05T21:52:49Z

tests/test_materialized_views.py

    AS SELECT t1.id, t1.name FROM t1
    """
-    for key in ("id", selectable.c.id):
+    for key in ("id", selectable.selected_columns.id):


The use of selected_columns appears to be an incorrect API for SQLAlchemy 2.x. This should likely be selectable.c.id or selectable.columns.id to properly access column objects in SQLAlchemy 2.x.

Copilot · 2025-09-05T21:52:49Z

tests/test_materialized_views.py

    AS SELECT t1.id, t1.name FROM t1
    """
-    for key in ("id", selectable.c.id):
+    for key in ("id", selectable.selected_columns.id):


The use of selected_columns appears to be an incorrect API for SQLAlchemy 2.x. This should likely be selectable.c.id or selectable.columns.id to properly access column objects in SQLAlchemy 2.x.

Copilot · 2025-09-05T21:52:49Z

tests/test_materialized_views.py

    AS SELECT t1.id, t1.name FROM t1
    """
-    for key in ("id", selectable.c.id):
+    for key in ("id", selectable.selected_columns.id):


The use of selected_columns appears to be an incorrect API for SQLAlchemy 2.x. This should likely be selectable.c.id or selectable.columns.id to properly access column objects in SQLAlchemy 2.x.

Copilot · 2025-09-05T21:52:50Z

tests/test_copy_command.py

        access_key_id=access_key_id,
        secret_access_key=secret_access_key,
-        format='JSON',
+        format=Format.json,


The use of Format.json, Compression.lzop, etc. suggests these are enum values, but there's no import or definition visible for these constants in the diff. Ensure these enum classes are properly imported and defined.

Suggested change

format=Format.json,

format=dialect.Format.json,

Copilot · 2025-09-05T21:52:50Z

tests/test_copy_command.py

        access_key_id=access_key_id,
        secret_access_key=secret_access_key,
-        compression='LZOP',
+        compression=Compression.lzop,


The use of Format.json, Compression.lzop, etc. suggests these are enum values, but there's no import or definition visible for these constants in the diff. Ensure these enum classes are properly imported and defined.

Copilot · 2025-09-05T21:52:50Z

tests/test_copy_command.py

        access_key_id=access_key_id,
        secret_access_key=secret_access_key,
-        compression='BZIP2',
+        compression=Compression.bzip2,


The use of Format.json, Compression.lzop, etc. suggests these are enum values, but there's no import or definition visible for these constants in the diff. Ensure these enum classes are properly imported and defined.

Copilot · 2025-09-05T21:52:50Z

tests/test_copy_command.py

        secret_access_key=secret_access_key,
        manifest=True,
-        format='JSON',
+        format=Format.json,


The use of Format.json, Compression.lzop, etc. suggests these are enum values, but there's no import or definition visible for these constants in the diff. Ensure these enum classes are properly imported and defined.

Copilot · 2025-09-05T21:52:51Z

tests/test_copy_command.py

+        format=Format.json,
        path_file='s3://mybucket/data/jsonpath.json',
-        compression='GZIP',
+        compression=Compression.gzip,


The use of Format.json, Compression.lzop, etc. suggests these are enum values, but there's no import or definition visible for these constants in the diff. Ensure these enum classes are properly imported and defined.

jagatsingh added 3 commits September 5, 2025 22:32

Add uv support for modern Python dependency management

7d0eca2

- Add pyproject.toml with uv configuration and project metadata - Update CI buildspec to use uv instead of tox - Update README with uv installation and usage instructions - Maintain backward compatibility with existing tox workflow

Update SqlAlchemy and Python versions

572e229

Add version note

029a5b4

Copilot AI review requested due to automatic review settings September 5, 2025 21:51

Copilot AI reviewed Sep 5, 2025

View reviewed changes

jagatsingh added 2 commits September 6, 2025 03:23

Ignore uv lock

8ba44d9

Update name to sqlalchemy2-redshift

ca627b9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update SQLAlchemy and Add uv support#1

Update SQLAlchemy and Add uv support#1
jagatsingh wants to merge 5 commits intomainfrom
uv-support

jagatsingh commented Sep 5, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Sep 5, 2025

Uh oh!

Copilot AI Sep 5, 2025

Uh oh!

Copilot AI Sep 5, 2025

Uh oh!

Copilot AI Sep 5, 2025

Uh oh!

Copilot AI Sep 5, 2025

Uh oh!

Copilot AI Sep 5, 2025

Uh oh!

Copilot AI Sep 5, 2025

Uh oh!

Copilot AI Sep 5, 2025

Uh oh!

Copilot AI Sep 5, 2025

Uh oh!

Copilot AI Sep 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


		In SQLAlchemy 2.0, the parent _get_column_info method was removed,
		so we implement the logic directly.

-        In SQLAlchemy 2.0, the parent _get_column_info method was removed,
-        so we implement the logic directly.
+        In SQLAlchemy 2.0, the parent _get_column_info method was removed,
+        so we implement the logic directly.
+        Parameters
+        ----------
+        name : str
+            The name of the column.
+        format_type : str
+            The PostgreSQL format type string for the column (e.g., 'varchar(30)', 'integer').
+        default : str or None
+            The default value for the column, if any.
+        notnull : bool
+            Whether the column is NOT NULL.
+        domains : dict
+            Domain information for the column, if any.
+        enums : dict
+            Enum information for the column, if any.
+        schema : str, optional
+            The schema name, if applicable.
+        encode : str, optional
+            Redshift-specific encoding for the column, if any.
+        comment : str, optional
+            Comment for the column, if any.
+        identity : dict, optional
+            Identity information for the column (SQLAlchemy 2.0+).
+        **kwargs
+            Additional keyword arguments.
+        Returns
+        -------
+        dict
+            A dictionary containing column information suitable for SQLAlchemy Table reflection.

Conversation

jagatsingh commented Sep 5, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 5, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants