Skip to content

Modify check_output to explicitly pass the errors object to is_valid_rij_list#10

Open
gregfaletto wants to merge 2 commits intojacobbien:masterfrom
gregfaletto:master
Open

Modify check_output to explicitly pass the errors object to is_valid_rij_list#10
gregfaletto wants to merge 2 commits intojacobbien:masterfrom
gregfaletto:master

Conversation

@gregfaletto
Copy link
Copy Markdown

No description provided.

@jacobbien
Copy link
Copy Markdown
Owner

Thanks! However, there's another call to is_valid_rij_list() in the function check_evals() that would also need to be changed.

@jacobbien
Copy link
Copy Markdown
Owner

In thinking about this more, it looks to me like errors is never really used within is_valid_rij_list(), so rather than passing it as an argument, I think we can just initialize errs <- c().

@gregfaletto
Copy link
Copy Markdown
Author

Yes, that makes sense to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants