PR #572: Season blend 90/10 (divisor 80→55) + MIN_PROB 0.57→0.60#441
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
 |
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| Docker |  |
May 15, 2026 5:07a.m. | Review ↗ |
| JavaScript | |
May 15, 2026 5:07a.m. | Review ↗ |
| Python | |
May 15, 2026 5:07a.m. | Review ↗ |
| SQL | |
May 15, 2026 5:07a.m. | Review ↗ |
| Secrets | |
May 15, 2026 5:07a.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
Up to standards ✅🟢 Issues
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the MIN_PROB threshold to 0.60 and adjusts the _season_weight_2026 calculation by reducing the divisor to 55.0 in tasklets.py. Feedback indicates that these updates were not mirrored in a duplicate file (api/tasklets.py), which could lead to inconsistent system behavior. Additionally, reviewers suggested updating surrounding comments to reflect the new values and provided a code suggestion to improve the precision of the season weight description.
| # At 0.55 with correct multipliers: 2-leg PP needs 55%^2 * 3 - 1 = -9.2% → still | ||
| # needs higher prob per leg, but combined_ev gate (+3%) now does the real work. | ||
| MIN_PROB = 0.57 | ||
| MIN_PROB = 0.60 # PR #572: May 15 schedule — raised from 0.57 |
There was a problem hiding this comment.
The update to MIN_PROB to 0.60 is not reflected in the duplicate file api/tasklets.py (line 288), which still uses 0.57. This inconsistency can lead to divergent behavior across the system. Additionally, the surrounding comments (lines 291 and 293) still refer to a value of 0.55 and should be updated to maintain documentation accuracy.
| _season_start = OPENING_DAY # 2026-03-26 | ||
| _days_played = max(0, (_today_pt() - _season_start).days) | ||
| _season_weight_2026 = round(min(1.0, _days_played / 80.0), 3) | ||
| _season_weight_2026 = round(min(1.0, _days_played / 55.0), 3) # PR #572: 90/10 by day 49 (May 15) |
There was a problem hiding this comment.
The season weight divisor update to 55.0 is missing from the duplicate definition in api/tasklets.py (line 2065). Additionally, the comment on line 2434 (context) still refers to game ~80, and the comment on this line (90/10) is slightly imprecise compared to the actual math (89.1%) and the PR description (89/11).
| _season_weight_2026 = round(min(1.0, _days_played / 55.0), 3) # PR #572: 90/10 by day 49 (May 15) | |
| _season_weight_2026 = round(min(1.0, _days_played / 55.0), 3) # PR #572: 89/11 by day 49 (May 15) |
1 participant
Changes
1. Season blend divisor: 80 → 55
2. MIN_PROB: 0.57 → 0.60
Summary by cubic
Accelerated season blending to 90% 2026 / 10% 2025 by day 49 (May 15) and 100% by day 55 by reducing the divisor from 80 to 55. Increased MIN_PROB from 0.57 to 0.60 to align with the May 15 schedule change and tighten pick thresholds.
Written for commit 80af002. Summary will update on new commits.