fix: correct path derivation in macOS update restart script#137
Merged
Conversation
The applyDmgUpdateOnQuit() method used path.dirname() twice on currentAppPath, which resolved to '/' instead of the app's parent directory (e.g. '/Applications'). This caused the update shell script to target '/Coderm.app' rather than '/Applications/Coderm.app', resulting in a failed restart after update installation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the macOS auto-update restart failure caused by incorrect path calculation in
applyDmgUpdateOnQuit().Problem
After downloading and extracting the update DMG, clicking "Install & Restart" would:
Root Cause
In
codermUpdateService.darwin.ts, theapplyDmgUpdateOnQuit()method usedpath.dirname()twice oncurrentAppPath:This caused the update shell script to target
/Coderm.appinstead of/Applications/Coderm.app, resulting in permission errors and failed restart.Fix
Remove the extra
path.dirname()call:Now
parentDircorrectly resolves to/Applications(or wherever the app is installed), and the update script properly replaces and relaunches the application.