Remove all V1 classes from library#37
Conversation
|
Thank you. I've created a new branch called 3.x. I guess we can also remove the V2 namespace from the other classes and update the examples. |
24f8c3f to
4dc6e69
Compare
|
All check from PHP 7.2 till PHP 8.1 has passed. Super improvement. 👍🏻 I was wondering why you want to introduce a 3.x branch and why we don't develop on master? I agree we are making multiple changes and improvement to the code. We have tagged the code with the latest tag 2.0.8. So when someone used the library within his project he can include a this tagged (2.0) version. We can merge this MR, tag this version with label 3.0 because it may be a breaking version. Within my project I can include iwd-nl/snelstart-php version ^2.0|^3.0 into my composer.json. Al the other can stick to version 2.0 for the time being and update to 3.0 when they feel the need. |
|
@manuelderuiter / @rojtjo Are we able to approve this PR and include it in the library. I saw we have a V3 branch. Only it will be easier to keep one main branch and work with tagged releases. By working with tagged releases composer should take care of updating the code. This PR may not be backwards compatible. Only the users are still able to used the tagged version. It will be wise to add a new tag to the library when these classes are removed. It will also remove one item from the list on updating the code base. |
|
I think it would be best to create a |
|
Clear. @rojtjo I'm not able to create a Are you - or one of the other contributors - able to review this PR? There needs to be a new release tag created - named Thanks in advice. |
…into remove_v1_classes_from_library
|
Sorry, I do not have access. As far as I know @manuelderuiter is the only maintainer of this repository. |
This will remove all the V1 classes from the library. These classes were already marked as deprecated in the deprecated.php file. No changes are made to the code.
It will be wise to make a new tag when this MR is merged.
Some classes within the V2 namespace are marked as deprecated. These classes are untouched.