Skip to content

Remove all V1 classes from library#37

Open
HVSoftware wants to merge 8 commits into
iwd-nl:masterfrom
HVSoftware:remove_v1_classes_from_library
Open

Remove all V1 classes from library#37
HVSoftware wants to merge 8 commits into
iwd-nl:masterfrom
HVSoftware:remove_v1_classes_from_library

Conversation

@HVSoftware
Copy link
Copy Markdown
Contributor

This will remove all the V1 classes from the library. These classes were already marked as deprecated in the deprecated.php file. No changes are made to the code.

It will be wise to make a new tag when this MR is merged.

Some classes within the V2 namespace are marked as deprecated. These classes are untouched.

@HVSoftware HVSoftware mentioned this pull request Jan 5, 2023
6 tasks
@manuelderuiter
Copy link
Copy Markdown
Contributor

Thank you. I've created a new branch called 3.x. I guess we can also remove the V2 namespace from the other classes and update the examples.

@HVSoftware HVSoftware force-pushed the remove_v1_classes_from_library branch from 24f8c3f to 4dc6e69 Compare January 6, 2023 08:58
@HVSoftware
Copy link
Copy Markdown
Contributor Author

All check from PHP 7.2 till PHP 8.1 has passed. Super improvement. 👍🏻

I was wondering why you want to introduce a 3.x branch and why we don't develop on master? I agree we are making multiple changes and improvement to the code. We have tagged the code with the latest tag 2.0.8. So when someone used the library within his project he can include a this tagged (2.0) version.

We can merge this MR, tag this version with label 3.0 because it may be a breaking version.

Within my project I can include iwd-nl/snelstart-php version ^2.0|^3.0 into my composer.json. Al the other can stick to version 2.0 for the time being and update to 3.0 when they feel the need.

@HVSoftware
Copy link
Copy Markdown
Contributor Author

@manuelderuiter / @rojtjo Are we able to approve this PR and include it in the library. I saw we have a V3 branch. Only it will be easier to keep one main branch and work with tagged releases. By working with tagged releases composer should take care of updating the code.

This PR may not be backwards compatible. Only the users are still able to used the tagged version.

It will be wise to add a new tag to the library when these classes are removed. It will also remove one item from the list on updating the code base.

@rojtjo
Copy link
Copy Markdown
Contributor

rojtjo commented Jun 30, 2023

I think it would be best to create a 2.x branch and develop v3 on the master branch. This gives you the ability to do security fixes in the 2.x branch and merge it into the master when needed.

@HVSoftware
Copy link
Copy Markdown
Contributor Author

Clear.

@rojtjo I'm not able to create a 2.x branch within this project from master. Are you able to create this branch? There is already a tag related to this branch.

Are you - or one of the other contributors - able to review this PR? There needs to be a new release tag created - named 3.0.0 - when it's approved and merge. This version will be updated in small steps. I'm not able to create releases also. I hope you can help me with this!

Thanks in advice.

@rojtjo
Copy link
Copy Markdown
Contributor

rojtjo commented Jul 1, 2023

Sorry, I do not have access. As far as I know @manuelderuiter is the only maintainer of this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants