Open
Conversation
irisqul
reviewed
Feb 2, 2026
| collector.books_genre['Оно'] = 'Ужасы' | ||
| assert collector.get_book_genre('Оно') == 'Ужасы' | ||
| #вывод списка по жанру | ||
| def test_get_books_with_specific_genre_positive(self): |
There was a problem hiding this comment.
Можно лучше: Здесь и далее. Проследи за соблюдением стиля PEP8 в твоем коде, внутри функций - отступы не делаются, между методами одного класса - отступ в 1 строку
irisqul
reviewed
Feb 2, 2026
tests.py
Outdated
| collector.delete_book_from_favorites('Убийство на улице Морг') | ||
| assert 'Убийство на улице Морг' not in collector.favorites | ||
| #вывод списка избранного | ||
| def test_get_list_of_favorites_books_positive(self) |
Owner
Author
There was a problem hiding this comment.
Я в конце не поставил двоеточие. Приложил скрин кода, где не хвататло двоеточия, код изменил прямо в Gitхабе. Наставник дал добро менять код здесь. Изменил код, и снова отправил очередной раз на проверку. Обновленный файл с изменениями находится в коммитах.
Теперь все нормально?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.