chore: include configuration class name in InvalidConfigurationException messages

Classes/Configuration/AbstractBaseConfiguration.php

@@ -22,11 +22,15 @@ abstract class AbstractBaseConfiguration
      */
     public function __construct(array $configuration)
     {
-        if (static::validate($configuration)->hasErrors()) {
+        $validationResult = static::validate($configuration);
+
+        if ($validationResult->hasErrors()) {
+            $configurationClassName = (new \ReflectionClass(get_called_class()))->getShortName();
+
             // TODO: This is crappy. Do it better!!!
-            $errorsAsString = implode("\n", static::validate($configuration)->getErrors());
+            $errorsAsString = implode("\n", $validationResult->getErrors());
 
-            throw new InvalidConfigurationException("Invalid configuration.\n" . $errorsAsString);
+            throw new InvalidConfigurationException("Invalid $configurationClassName. " . $errorsAsString);
         }
         $this->configuration = $configuration;
     }

Tests/Unit/Configuration/IconConfigurationTest.php

@@ -1,6 +1,7 @@
 <?php
 namespace ITplusX\FlexiblePages\Tests\Unit\Configuration;
 
+use ITplusX\FlexiblePages\Configuration\Exceptions\InvalidConfigurationException;
 use ITplusX\FlexiblePages\Configuration\IconConfiguration;
 use ITplusX\FlexiblePages\Page\Icon;
 use ITplusX\FlexiblePages\Tests\Fixtures\PageTypesConfigurationFixture;
@@ -69,4 +70,12 @@ public function testIdentifierCreationFromConfigurationWithPathOnly()
 
         $this->assertSame('icon-111', $icon->getIdentifier());
     }
+
+    public function testInvalidConfigurationExceptionMessageContainsClassName()
+    {
+        $this->expectException(InvalidConfigurationException::class);
+        $this->expectExceptionMessageRegExp('/IconConfiguration/');
+
+        new IconConfiguration([]);
+    }
 }

Tests/Unit/Configuration/PageTypeConfigurationTest.php

@@ -1,6 +1,7 @@
 <?php
 namespace ITplusX\FlexiblePages\Tests\Unit\Configuration;
 
+use ITplusX\FlexiblePages\Configuration\Exceptions\InvalidConfigurationException;
 use ITplusX\FlexiblePages\Configuration\PageTypeConfiguration;
 use ITplusX\FlexiblePages\Tests\Fixtures\PageTypesConfigurationFixture;
 use PHPUnit\Framework\TestCase;
@@ -29,4 +30,12 @@ public function testConstructionOfPageTypeFromConfiguration()
 
         $this->assertSame($label, $pageType->getLabel());
     }
+
+    public function testInvalidConfigurationExceptionMessageContainsClassName()
+    {
+        $this->expectException(InvalidConfigurationException::class);
+        $this->expectExceptionMessageRegExp('/PageTypeConfiguration/');
+
+        new PageTypeConfiguration([]);
+    }
 }