fix: add missing await on render_template service call#344
Merged
privateip merged 1 commit intoitential:develfrom Mar 18, 2026
Merged
Conversation
render_template() called client.configuration_manager.render_template() without await, returning a coroutine object instead of the rendered string. Because RenderTemplateResponse.result is typed as str, Pydantic raised ValidationError: Input should be a valid string, input_type=coroutine. In a looser-typed model this would silently return a coroutine repr string — a subtle data-correctness failure. Closes itential#336 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
privateip
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
render_template()calledclient.configuration_manager.render_template()withoutawait, returning a coroutine object instead of the rendered stringRenderTemplateResponse.resultis typed asstr, Pydantic raisedValidationError: Input should be a valid string, input_type=coroutineawaitand 6 regression testsTest plan
make cipasses on the branchtests/test_tools_configuration_manager.pyverify the tool awaits its service callrender_templatereturns the correctly rendered string against a live IAP instanceFixes #336
🤖 Generated with Claude Code