fix: replace sys.exit in fatal() with raise SystemExit#123
Merged
privateip merged 1 commit intoitential:mainfrom Mar 19, 2026
Merged
fix: replace sys.exit in fatal() with raise SystemExit#123privateip merged 1 commit intoitential:mainfrom
privateip merged 1 commit intoitential:mainfrom
Conversation
Member
privateip
commented
Mar 18, 2026
privateip
commented
- Replace sys.exit(1) and print() with raise SystemExit(1) in fatal()
- Change return type annotation from None to NoReturn
- Add NoReturn import from typing
- Remove stderr print — message is captured in the log at FATAL level
- Update tests to assert SystemExit via pytest.raises instead of mocking sys.exit and builtins.print
- Update docstring and module-level example to reflect new behavior
- Replace sys.exit(1) and print() with raise SystemExit(1) in fatal() - Change return type annotation from None to NoReturn - Add NoReturn import from typing - Remove stderr print — message is captured in the log at FATAL level - Update tests to assert SystemExit via pytest.raises instead of mocking sys.exit and builtins.print - Update docstring and module-level example to reflect new behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.