Add warning notes if helm charts Istio version is already EOL#1294
Open
zufardhiyaulhaq wants to merge 3 commits intoistio:masterfrom
Open
Add warning notes if helm charts Istio version is already EOL#1294zufardhiyaulhaq wants to merge 3 commits intoistio:masterfrom
zufardhiyaulhaq wants to merge 3 commits intoistio:masterfrom
Conversation
Signed-off-by: zufardhiyaulhaq <zufardhiyaulhaq@gmail.com>
istio-testing
added
the
size/M
Member
Author
|
cc @howardjohn |
Signed-off-by: zufardhiyaulhaq <zufardhiyaulhaq@gmail.com>
howardjohn
reviewed
Dec 7, 2022
| Version string `json:"version"` | ||
| // EOLDate specifies what is the date when this Istio version become EOL | ||
| // Should be in format "yyyy-mm" | ||
| EOLDate string `json:"eolDate"` |
Member
There was a problem hiding this comment.
If we already have to update istioctl binary directly it seems like we could just update the helm notes directly as well? We can have a test to check they are in sync if needed
Will defer to @ericvn
Member
Author
There was a problem hiding this comment.
do you mean to update the helm notes directly on istio/istio repository?
Signed-off-by: zufardhiyaulhaq <zufardhiyaulhaq@gmail.com>
Member
Author
|
@ericvn can you help here? |
Member
Author
|
cc @istio/wg-test-and-release-maintainers please help review |
Member
istio-testing
added
the
needs-rebase
Contributor
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zufardhiyaulhaq zufardhiyaulhaq@gmail.com
fix istio/istio#41747, introduce a warning if the current date is near or after EOL of the date defined in the release builder.