Add chaos testing scripts and verification scenarios for SQLite and SQL Server#82
Add chaos testing scripts and verification scenarios for SQLite and SQL Server#82isdaniel wants to merge 1 commit into
Conversation
…QL Server - Introduced `scenario5_verify.sql` to verify high-volume data replication (3M rows) in SQL Server. - Created `run_chaos_tests_sqlite.sh` for executing chaos tests with SQLite as the destination. - Developed `run_chaos_tests_sqlserver.sh` for executing chaos tests with SQL Server as the destination. - Implemented `run_pgbench_chaos_test_sqlite.sh` for performance testing with pgbench on SQLite. - Implemented `run_pgbench_chaos_test_sqlserver.sh` for performance testing with pgbench on SQL Server. - Added logging and cleanup functionalities to all scripts for better traceability and resource management.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request significantly expands the project's testing infrastructure by introducing comprehensive chaos and performance (pgbench) testing suites for SQL Server and SQLite destinations. Key changes include updating the Dockerfile to support feature-based builds, extending the Makefile with specialized test targets, and adding various docker-compose configurations and shell scripts to orchestrate the testing environments. The review feedback highlights a critical mismatch in the container shutdown timeout that could lead to data loss, identifies security vulnerabilities regarding cleartext passwords in connection strings and command-line arguments, and suggests performance optimizations for SQL Server schema definitions and shell scripting best practices.
1 participant
scenario5_verify.sqlto verify high-volume data replication (3M rows) in SQL Server.run_chaos_tests_sqlite.shfor executing chaos tests with SQLite as the destination.run_chaos_tests_sqlserver.shfor executing chaos tests with SQL Server as the destination.run_pgbench_chaos_test_sqlite.shfor performance testing with pgbench on SQLite.run_pgbench_chaos_test_sqlserver.shfor performance testing with pgbench on SQL Server.