Add chaos testing scripts and verification scenarios for SQLite and SQL Server#81
Add chaos testing scripts and verification scenarios for SQLite and SQL Server#81isdaniel wants to merge 4 commits into
Conversation
…QL Server - Introduced `scenario5_verify.sql` to verify high-volume data replication (3M rows) in SQL Server. - Created `run_chaos_tests_sqlite.sh` for executing chaos tests with SQLite as the destination. - Developed `run_chaos_tests_sqlserver.sh` for executing chaos tests with SQL Server as the destination. - Implemented `run_pgbench_chaos_test_sqlite.sh` for performance testing with pgbench on SQLite. - Implemented `run_pgbench_chaos_test_sqlserver.sh` for performance testing with pgbench on SQL Server. - Added logging and cleanup functionalities to all scripts for better traceability and resource management.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces comprehensive chaos and performance testing infrastructure for the CDC application, specifically targeting SQLite and SQL Server destinations. Changes include updated Docker configurations, environment files, and a suite of shell scripts and SQL scenarios to automate testing under adverse conditions. Feedback focuses on ensuring LSN metadata persistence across container restarts, fixing a logic error in the SQLite verification SQL, improving shell script robustness by avoiding ls parsing, and addressing security concerns regarding the exposure of database passwords in process lists and connection strings.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces comprehensive chaos and performance testing infrastructure for SQL Server and SQLite destinations, including new Docker Compose configurations, environment files, and automated test runners. The changes also update the build process to support feature-based compilation. Feedback focuses on enhancing the security and robustness of the testing scripts by recommending the removal of hardcoded credentials in the Makefile, improving environment variable loading logic, and ensuring proper quoting of command paths in shell scripts to prevent execution errors.
1 participant
scenario5_verify.sqlto verify high-volume data replication (3M rows) in SQL Server.run_chaos_tests_sqlite.shfor executing chaos tests with SQLite as the destination.run_chaos_tests_sqlserver.shfor executing chaos tests with SQL Server as the destination.run_pgbench_chaos_test_sqlite.shfor performance testing with pgbench on SQLite.run_pgbench_chaos_test_sqlserver.shfor performance testing with pgbench on SQL Server.