Add chaos testing scripts and verification scenarios for SQLite and SQL Server#80
Add chaos testing scripts and verification scenarios for SQLite and SQL Server#80isdaniel wants to merge 5 commits into
Conversation
…QL Server - Introduced `scenario5_verify.sql` to verify high-volume data replication (3M rows) in SQL Server. - Created `run_chaos_tests_sqlite.sh` for executing chaos tests with SQLite as the destination. - Developed `run_chaos_tests_sqlserver.sh` for executing chaos tests with SQL Server as the destination. - Implemented `run_pgbench_chaos_test_sqlite.sh` for performance testing with pgbench on SQLite. - Implemented `run_pgbench_chaos_test_sqlserver.sh` for performance testing with pgbench on SQL Server. - Added logging and cleanup functionalities to all scripts for better traceability and resource management.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request expands the project's testing capabilities by adding support for SQLite and SQL Server destinations. It includes new Docker Compose files, environment configurations, and initialization scripts, alongside significant Makefile updates to manage chaos and performance testing for these new targets. The review feedback identifies critical bugs in shell script environment parsing that would fail with spaces in connection strings and highlights a common Bash pitfall where the "local" keyword masks command exit statuses, potentially bypassing error handling.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request expands the project's testing capabilities by introducing dedicated chaos and performance testing suites for SQL Server and SQLite destinations. The changes include new Docker Compose environments, destination-specific configuration files, and automated test runners. The review feedback highlights several areas for improvement: addressing security risks associated with hardcoded credentials, reducing extensive code duplication in the new shell scripts and Makefile, centralizing complex health check logic, and replacing magic numbers in SQL verification scripts with variables to enhance maintainability.
…ironment loading in chaos test scripts
…e expected row count logic and improve variable usage in chaos test scripts
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces comprehensive chaos and performance testing for SQL Server and SQLite destinations, including new Docker Compose setups, environment configurations, and automated test scripts. The build process is also updated to support conditional compilation of destination features via Docker build arguments. Feedback focuses on improving the reliability of test cleanup scripts during container restarts, removing unused code, and refactoring the Makefile to eliminate duplication and hardcoded credentials.
…e and SQL Server; streamline code by using 'set -a' and 'source'
1 participant
scenario5_verify.sqlto verify high-volume data replication (3M rows) in SQL Server.run_chaos_tests_sqlite.shfor executing chaos tests with SQLite as the destination.run_chaos_tests_sqlserver.shfor executing chaos tests with SQL Server as the destination.run_pgbench_chaos_test_sqlite.shfor performance testing with pgbench on SQLite.run_pgbench_chaos_test_sqlserver.shfor performance testing with pgbench on SQL Server.