Fix a subtle frequency ID bookkeeping issue#244
Merged
bhawkins merged 1 commit intoisce-framework:developfrom Mar 24, 2026
Merged
Fix a subtle frequency ID bookkeeping issue#244bhawkins merged 1 commit intoisce-framework:developfrom
bhawkins merged 1 commit intoisce-framework:developfrom
Conversation
rad-eng-59
approved these changes
Mar 24, 2026
Contributor
rad-eng-59
left a comment
There was a problem hiding this comment.
LGTM. Thank you for the fix.
Tyler-g-hudson
pushed a commit
that referenced
this pull request
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #231 we introduced a
freq_bandargument to theAntennaPatternconstructor. The corresponding modification to focus.py script accidentally used the output frequency label instead of the one for the input file. These can be different for quasi-dual modes or mixed mode cases involving 77 MHz, which can result in an error message likeThis one-line patch just makes sure to use the subband label from the input data.