Fix solid earth tides computation fail when frequencyA is missing#243
Open
xhuang-jpl wants to merge 29 commits intoisce-framework:developfrom
Open
Fix solid earth tides computation fail when frequencyA is missing#243xhuang-jpl wants to merge 29 commits intoisce-framework:developfrom
xhuang-jpl wants to merge 29 commits intoisce-framework:developfrom
Conversation
added 27 commits
September 19, 2023 20:40
added 2 commits
March 23, 2026 17:08
Tyler-g-hudson
approved these changes
Mar 24, 2026
Contributor
Tyler-g-hudson
left a comment
Tyler-g-hudson
left a comment
There was a problem hiding this comment.
LGTM, just one question for clarification
| wavelength = isce3.core.speed_of_light / \ | ||
| h5_obj[f'{gunw_obj.GridsPath}/frequencyA/centerFrequency'][()] | ||
| # Wavelength in meters; fall back to frequencyB if frequencyA is not found | ||
| for freq in ('A', 'B'): |
Contributor
There was a problem hiding this comment.
Is there a reason why we capture first available of A or B instead of calculating a different datacube for each? They would have different values, wouldn't they?
Contributor
Author
There was a problem hiding this comment.
good question @Tyler-g-hudson, for NISAR InSAR processing, we are always processing frequencyA even if the product has both freqA and freqB. This fix is for users who need to process the freqB stand alone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where solid earth tides computation fails when
frequencyAis missing. The logic now falls back tofrequencyBif available, and raises an error if neither exists.