RSLC: Fix broadcasting of subswath assignment in constant-PRF case#242
Merged
hfattahi merged 1 commit intoisce-framework:developfrom Mar 23, 2026
Merged
RSLC: Fix broadcasting of subswath assignment in constant-PRF case#242hfattahi merged 1 commit intoisce-framework:developfrom
hfattahi merged 1 commit intoisce-framework:developfrom
Conversation
Tyler-g-hudson
pushed a commit
that referenced
this pull request
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bug related to numpy broadcasting was introduced in #221 for fixed-PRF cases. For code like
You might get an error like
I was surprised by this failure since the workflow unit test is fixed PRF. However, it didn't catch this case because it only has a single subswath, so numpy was able to figure out the broadcasting rule. The other data I tested with was all dithered PRF.
It's easy to fix just by leaving a singleton dimension so that numpy knows to broadcast over the other two.