Conversation
Initially, this just shows time-sorted work to do. There are plans to expand this significantly in the future, including the ability to dismiss notifications.
(the student overview page is already behind it)
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…ations [VRT] Update baselines for feature/my-ada-notifications
This reverts commit 61cc795.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2053 +/- ##
==========================================
+ Coverage 43.08% 43.13% +0.05%
==========================================
Files 579 580 +1
Lines 24917 24955 +38
Branches 8258 8275 +17
==========================================
+ Hits 10735 10764 +29
- Misses 14125 14134 +9
Partials 57 57 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sjd210
left a comment
sjd210
left a comment
There was a problem hiding this comment.
Mostly looking good, but a couple of small things to look at.
Also somewhat unrelated since I know that we're not requiring dismissing banners for this initial work, but do we have a plan for how we're going to do that dismissing yet? I remember talking about it, but did we ever reach a decision?
| <IconCard className={"without-margin"} card={{ | ||
| title: "Assigned to me", | ||
| icon: {name: "icon-person-check", color: "secondary"}, | ||
| tag: counts.assignments > 0 ? `${counts.assignments} to do` : undefined, |
There was a problem hiding this comment.
I imagine this wasn't requested so more of a thought than a request, but I would imagine that seeing these counts in the (expanded) sidebar so that they're always visible within the My Ada section would make sense. It would be a similar idea to them appearing in the header dropdown as they currently do.
There was a problem hiding this comment.
I had actually meant to add this, just forgot 😔. I think more people will navigate with the sidebar, so agreed it makes sense.
|
(Waiting on release to merge) |
4 participants
Hopefully the last set of changes before Ada are happy with the sidebar. Based off of #2026, please ensure that is merged before reviewing this.
Adds notification-style banners to the top of the overview pages. There are plans to expand these to show more types of notification and to make them dismissible, but for now these are simply permanent banners, one for each active assignment / test.