Merged
Conversation
first-ironsoftware
requested review from
chaknith-ironsoftware and
mee-ironsoftware
mee-ironsoftware
approved these changes
May 22, 2025
Provides overloaded constructors and From methods for AnyBitmap, allowing to omit the preserveOriginalFormat parameter. The default value for preserveOriginalFormat is true. This change maintains backwards compatibility while simplifying the API for common use cases.
jordi-ironsoftware
suggested changes
May 30, 2025
| } | ||
|
|
||
| /// <summary> | ||
| /// Create a new Bitmap from a a Byte Span. |
Contributor
There was a problem hiding this comment.
from a a Byte Span -> from a byte span
| } | ||
|
|
||
| /// <summary> | ||
| /// Create a new Bitmap from a a Byte Array. |
Contributor
There was a problem hiding this comment.
from a a Byte Array -> from a byte array
| } | ||
|
|
||
| /// <summary> | ||
| /// Construct a new Bitmap from a Uri |
Contributor
There was a problem hiding this comment.
from a Uri -> from a Uri.
| } | ||
|
|
||
| /// <summary> | ||
| /// Construct a new Bitmap from a Uri |
| } | ||
|
|
||
| /// <summary> | ||
| /// Construct a new Bitmap from a Uri |
Comment on lines
+43
to
+44
| - Fixes the issue of some images are auto-rotated when loading as AnyBitmap. | ||
| - Adds an option called preserveOriginalFormat to download input image as Rgba32 via AnyBitmap.</releaseNotes> |
Contributor
There was a problem hiding this comment.
nit: normalize the spacing to be spaces only (no tabs)
| } | ||
|
|
||
| /// <summary> | ||
| /// Construct a new Bitmap from binary data (byte span). |
Contributor
There was a problem hiding this comment.
I think it'd be better to clarify the input type in the summary as Construct a new Bitmap out of binary data with a byte span.
| } | ||
|
|
||
| /// <summary> | ||
| /// Construct a new Bitmap from binary data (bytes). |
Contributor
There was a problem hiding this comment.
Same here: Construct a new Bitmap out of binary data with a byte array.
| /// <summary> | ||
| /// Construct a new Bitmap from binary data (bytes). | ||
| /// </summary> | ||
| /// <param name="bytes">A ByteArray of image data in any common format.</param> |
Contributor
There was a problem hiding this comment.
ByteArray should be byte array
| @@ -474,22 +482,41 @@ public static AnyBitmap FromSpan(ReadOnlySpan<byte> span, bool preserveOriginalF | |||
| /// Create a new Bitmap from a a Byte Array. | |||
| /// </summary> | |||
| /// <param name="bytes">A ByteArray of image data in any common format.</param> | |||
Contributor
There was a problem hiding this comment.
A ByteArray -> a byte array
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Lists
SixLabors.ImageSharpandSixLabors.ImageSharp.Drawingversion to address potential vulnerability issue.