[_795] allow options to be accessed as attributes of metadata obj#796
[_795] allow options to be accessed as attributes of metadata obj#796d-w-moore wants to merge 5 commits intoirods:mainfrom
Conversation
alanking
left a comment
alanking
left a comment
There was a problem hiding this comment.
Please address or explicitly ignore Ruff as you see fit.
d-w-moore
changed the title
korydraughn
left a comment
korydraughn
left a comment
There was a problem hiding this comment.
Good stuff so far.
There are a few more things being reported by ruff.
|
After some discussion, the current state of this PR is that it is working and all that's left to do is address the ruff report and code review comments. |
korydraughn
left a comment
korydraughn
left a comment
There was a problem hiding this comment.
Squash to taste if everything is working as intended.
Co-authored-by: Kory Draughn <korydraughn@ymail.com>
Ok . added test. Will do the squash after I see all tests are passing |
alanking
left a comment
alanking
left a comment
There was a problem hiding this comment.
Looking good. Just had one question. Please notify when ready
| if __name__ == "__main__": | ||
| # let the tests find the parent irods lib | ||
| sys.path.insert(0, os.path.abspath("../..")) | ||
| unittest.main() |
There was a problem hiding this comment.
Ruff said to delete this? Does this affect how we run tests or any of our documentation for running tests?
There was a problem hiding this comment.
Funny, I'm not seeing the notation ruff made. Is there a way to find it?
What was the specific comment or notation it made?
That line is there so that the test can be run as a script, from within the test directory.
There was a problem hiding this comment.
I guess I was wondering why this line was removed. I figured Ruff suggested its removal, but maybe not.
There was a problem hiding this comment.
I guess I was wondering why this line was removed. I figured Ruff suggested its removal, but maybe not.
Oh! Good eye. The deletion was not deliberate. Reversing it.
There was a problem hiding this comment.
I see tests failing now. Is this change related to the results of the test runs in GHAs?
3 participants
No description provided.