Conversation
saki7
added a commit
to iris-cpp/x4
that referenced
this pull request
Mar 12, 2026
Companion PR for iris-cpp/iris#53
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During transition of my non-iris project, I found that ASan related flags are not quite usable in certain scenario. In game projects, we have to link our library to the game engine SDK that is built with some preconfigured flags, which makes it often not that easy to "just enable ASan everywhere".
Ideally, we should split test-related common targets (i.e.
iris_cxx_testiris_cxx_test_external) into two variations: sanitizer-enabled version and disabled version. However, that requires a lot of work to implement because the normal CMake dependencies added byFetchContent(e.g. Catch2) cannot be duplicated, because their targets are defined inside their own hard-coded CMake namespace (e.g.Catch2::Catch2).In order to do the complete fix, I think we need to use
ExternalProject_Add(instead ofFetchContent) and build two versions of all dependent libraries. That should be addressed in a future PR.This PR adds a new option
IRIS_TEST_USE_SANITIZER(defaulted toON). Users may turn it OFF to globally disable sanitizer in non-sanitizer-applicable projects.