fix: Align matmul batch broadcasting semantics#372
Draft
sjain-stanford wants to merge 1 commit intomainfrom
Draft
fix: Align matmul batch broadcasting semantics#372sjain-stanford wants to merge 1 commit intomainfrom
sjain-stanford wants to merge 1 commit intomainfrom
Conversation
Use PyTorch-style right-aligned broadcasting for matmul batch dimensions while preserving the existing rank >= 2 tensor contract. Reject divisible but non-broadcastable batch dimensions, allow unequal batch-rank inputs, and infer default output strides from the finalized output dimensions. Co-Authored-By: GPT 5.5 <codex@openai.com> Signed-off-by: Sambhav Jain <sambhav@alumni.stanford.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary