Bugfix of baseline_chars (missing comma)#87
Merged
Conversation
Contributor
Author
I downloaded it, extracted the zip, and did a diff between the PNGs, but there is no difference... |
pelson
reviewed
May 4, 2026
Member
pelson
left a comment
pelson
left a comment
There was a problem hiding this comment.
(Kerning is fluctuating, but it will be fixed in a separate PR.fixed.)
Now that I look deeper, I note that if we're auto-kerning all the letters then we should just go straight to fix the bounding box of the character itself, and leave kerning for specific pairs...
I have a few changes after this one that I'll propose in a PR.
pelson
reviewed
May 4, 2026
pelson
reviewed
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #67.
['a' 'e', ...]was interpreted as['ae', ...]and did not match a and e.With this fix, the recognition of the baseline is improved, and the variation within
_spansis also reduced. As a result, c and s get closer to the baseline, and their positions at low DPI are improved.(Kerning is fluctuating,
but it will be fixed in a separate PR.fixed.)