Skip to content

fixes #20 add default export to buffer-es6.js module#21

Open
habdelra wants to merge 1 commit into
ionic-team:masterfrom
habdelra:20-buffer-default-export
Open

fixes #20 add default export to buffer-es6.js module#21
habdelra wants to merge 1 commit into
ionic-team:masterfrom
habdelra:20-buffer-default-export

Conversation

@habdelra
Copy link
Copy Markdown

@habdelra habdelra commented Feb 2, 2021

fixes #20 add default export to buffer-es6.js module

@remorses
Copy link
Copy Markdown

Can this be merged please?

@lemoustachiste
Copy link
Copy Markdown

I am experiencing this issue but I am not sure of the side effects of this change.
It would be all in all a breaking change and it's not highlighted as such in the commit.
I think the better fix would be at the moment of injecting the code into the build, replacing import buffer from 'buffer' by import * as buffer from 'buffer'.

I am not a maintainer of this library so this is just my 2 cents trying to deal with this issue.

@ralyodio
Copy link
Copy Markdown

I'm needing this. For some reason I get an error when trying to do:

buffer: 'rollup-plugin-node-polyfills/polyfills/buffer-es6', as an alias in vite/sveltekit.

@ralyodio
Copy link
Copy Markdown

Can someone merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants