Skip to content

fix: use unique filename per image in gallery fallback path #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andredestro merged 2 commits into from
Apr 28, 2026
+10 −4
Merged

fix: use unique filename per image in gallery fallback path #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12c70dd
fix: use unique filename per image in gallery fallback path
andredestro Apr 27, 2026
57a2107
chore(release): prepare for 1.0.1 release
andredestro Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

The changes documented here do not include those from the original repository.

## [1.0.1]

### 2026-04-27

- Fix: gallery multiple selection returning duplicate `uri` and `webPath` on Android devices where the MediaStore `_data` column is unavailable. Each selected image now gets a unique cache filename via `UUID.randomUUID()`.

## [1.0.0]

### 2026-04-10
Expand Down
4 changes: 2 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@
<modelVersion>4.0.0</modelVersion>
<groupId>io.ionic.libs</groupId>
<artifactId>ioncamera-android</artifactId>
<version>1.0.0</version>
</project>
<version>1.0.1</version>
</project>
4 changes: 2 additions & 2 deletions src/main/kotlin/io/ionic/libs/ioncameralib/helper/IONCAMRFileHelper.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,7 +566,7 @@ class IONCAMRFileHelper: IONCAMRFileHelperInterface {
var read: Int
val buffer = ByteArray(8 * 1024)
val extension = MimeTypeMap.getSingleton().getExtensionFromMimeType(mimeType) ?: "dat"
val targetFile = createCaptureFile(context, "file.${extension}")
val targetFile = createCaptureFile(context, "${UUID.randomUUID()}.${extension}")
Copy link
Copy Markdown
Contributor

@OS-pedrogustavobilro OS-pedrogustavobilro Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this seems to fix the issue, it brings up the situation of the cache size growing with the amount of files being returned from the gallery. But that also applies to the photos taken with camera.

Unlike iOS, the cached images are not cleared on app restart, only the videos.

That's possibly a discrepancy we should address one day, but guess this PR may not be the place for it (unless you disagree).

val outputStream: OutputStream = FileOutputStream(targetFile)
while (inputStream.read(buffer).also { read = it } != -1) {
outputStream.write(buffer, 0, read)
Expand All @@ -579,4 +579,4 @@ class IONCAMRFileHelper: IONCAMRFileHelperInterface {
}
return targetFile
}
}
}
Loading