Add IVA responsibility legends and punto de venta start dates#95
Add IVA responsibility legends and punto de venta start dates#95methodofaction merged 10 commits intomainfrom
Conversation
pmenendz
left a comment
There was a problem hiding this comment.
I don't love the way we are mapping the start activity date. Isn't there another field we can use? Isn't it the operation date or something like that?
…bove the invoice number)
There was a problem hiding this comment.
Pull request overview
This PR enhances Argentine (ARCA) invoice rendering by adding IVA responsibility legends for supplier/customer and supporting “Inicio de actividades” via party registration/address metadata, while also refreshing Argentine example outputs and the examples gallery index.
Changes:
- Add ARCA-specific rendering helpers for VAT legends and document-type titles, and wire them into the invoice/contact templates.
- Extend invoice line rendering to keep table alignment when exemption columns are present for discount/charge rows.
- Update ES/PT/GL locale strings and refresh example JSON/HTML plus the examples index.
Reviewed changes
Copilot reviewed 19 out of 24 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
components/regimes/ar/arca.templ |
Adds ARCAVATLegend and TitleType rendering for ARCA documents. |
components/regimes/ar/arca_templ.go |
Generated output for the updated AR templates. |
components/regimes/ar/ar.go |
Implements VAT-status-to-legend mapping and doc-type-based supplier legend logic. |
components/bill/contact.templ |
Injects ARCA VAT legend into supplier/customer blocks via org.Party children. |
components/bill/contact_templ.go |
Generated output for contact template changes. |
components/org/party.templ |
Allows rendering extra child content inside party blocks. |
components/org/party_templ.go |
Generated output for party template changes. |
components/bill/invoice.templ |
Prefers AR TitleType in the invoice header title coalescing chain. |
components/bill/invoice_templ.go |
Generated output for invoice template changes. |
components/bill/lines.templ |
Adds empty exemption cells for discount/charge rows when exemption columns are present. |
components/bill/lines_templ.go |
Generated output for lines template changes. |
locales/es/app.yml |
Adds regimes.ar.title.* mappings; adjusts some ES labels. |
locales/pt/app.yml |
Updates PT period labels. |
locales/gl/app.yml |
Updates GL period labels. |
assets/styles/invoice.css |
Styles ARCA doc-type box and adds uppercase styling for VAT legends. |
examples/index.html |
Adds new example cards/entries for refreshed examples. |
examples/ar-arca-invoice*.json |
Updates ARCA invoice sample data (concept, ordering period, payment, totals, notes, registration). |
examples/ar-arca-liquido-producto.json |
Adds a new ARCA “líquido producto” example envelope. |
examples/out/ar-arca-*.html |
Refreshes rendered ARCA example outputs. |
examples/out/es-*-credit-note*.html |
Updates rendered ES examples to match updated column labels. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pmenendz
left a comment
There was a problem hiding this comment.
LGTM!
I'd just check Copilot's comments
|
@copilot resolve the merge conflicts in this pull request |
Agent-Logs-Url: https://github.com/invopop/gobl.html/sessions/21a5fe88-84b4-4b89-99c8-a1f4b73d10ee Co-authored-by: methodofaction <51445+methodofaction@users.noreply.github.com>
The GOBL The invoice's If you'd prefer a more structured approach, the cleanest option would be adding an ARCA-specific extension key (e.g. |
Improves Argentine ARCA presentation on PDF invoices: IVA responsibility legends for supplier and customer, “Inicio de actividades” from address meta. Also Refreshes AR example JSON/HTML and the examples gallery index.