Skip to content

Add IVA responsibility legends and punto de venta start dates#95

Merged
methodofaction merged 10 commits intomainfrom
arca-legend
Apr 16, 2026
Merged

Add IVA responsibility legends and punto de venta start dates#95
methodofaction merged 10 commits intomainfrom
arca-legend

Conversation

@methodofaction
Copy link
Copy Markdown
Contributor

Improves Argentine ARCA presentation on PDF invoices: IVA responsibility legends for supplier and customer, “Inicio de actividades” from address meta. Also Refreshes AR example JSON/HTML and the examples gallery index.

image

@methodofaction methodofaction requested a review from pmenendz April 6, 2026 14:15
Copy link
Copy Markdown
Contributor

@pmenendz pmenendz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love the way we are mapping the start activity date. Isn't there another field we can use? Isn't it the operation date or something like that?

Comment thread examples/ar-arca-invoice.json Outdated
Comment thread components/regimes/ar/ar.go Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances Argentine (ARCA) invoice rendering by adding IVA responsibility legends for supplier/customer and supporting “Inicio de actividades” via party registration/address metadata, while also refreshing Argentine example outputs and the examples gallery index.

Changes:

  • Add ARCA-specific rendering helpers for VAT legends and document-type titles, and wire them into the invoice/contact templates.
  • Extend invoice line rendering to keep table alignment when exemption columns are present for discount/charge rows.
  • Update ES/PT/GL locale strings and refresh example JSON/HTML plus the examples index.

Reviewed changes

Copilot reviewed 19 out of 24 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
components/regimes/ar/arca.templ Adds ARCAVATLegend and TitleType rendering for ARCA documents.
components/regimes/ar/arca_templ.go Generated output for the updated AR templates.
components/regimes/ar/ar.go Implements VAT-status-to-legend mapping and doc-type-based supplier legend logic.
components/bill/contact.templ Injects ARCA VAT legend into supplier/customer blocks via org.Party children.
components/bill/contact_templ.go Generated output for contact template changes.
components/org/party.templ Allows rendering extra child content inside party blocks.
components/org/party_templ.go Generated output for party template changes.
components/bill/invoice.templ Prefers AR TitleType in the invoice header title coalescing chain.
components/bill/invoice_templ.go Generated output for invoice template changes.
components/bill/lines.templ Adds empty exemption cells for discount/charge rows when exemption columns are present.
components/bill/lines_templ.go Generated output for lines template changes.
locales/es/app.yml Adds regimes.ar.title.* mappings; adjusts some ES labels.
locales/pt/app.yml Updates PT period labels.
locales/gl/app.yml Updates GL period labels.
assets/styles/invoice.css Styles ARCA doc-type box and adds uppercase styling for VAT legends.
examples/index.html Adds new example cards/entries for refreshed examples.
examples/ar-arca-invoice*.json Updates ARCA invoice sample data (concept, ordering period, payment, totals, notes, registration).
examples/ar-arca-liquido-producto.json Adds a new ARCA “líquido producto” example envelope.
examples/out/ar-arca-*.html Refreshes rendered ARCA example outputs.
examples/out/es-*-credit-note*.html Updates rendered ES examples to match updated column labels.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread components/regimes/ar/arca.templ
Comment thread locales/pt/app.yml Outdated
Comment thread locales/pt/app.yml Outdated
Comment thread locales/gl/app.yml Outdated
Comment thread locales/gl/app.yml Outdated
Comment thread locales/es/app.yml
Comment thread locales/es/app.yml
Copy link
Copy Markdown
Contributor

@pmenendz pmenendz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I'd just check Copilot's comments

@methodofaction
Copy link
Copy Markdown
Contributor Author

@copilot resolve the merge conflicts in this pull request

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 16, 2026

I don't love the way we are mapping the start activity date. Isn't there another field we can use? Isn't it the operation date or something like that?

The GOBL org.Registration struct doesn't have a dedicated date field — Other is the most semantically appropriate slot in the current GOBL model for free-form registration details that don't fit anywhere else.

The invoice's op_date (OperationDate) field refers to when the invoiced transaction became effective, which is different from the company's "Inicio de actividades" date.

If you'd prefer a more structured approach, the cleanest option would be adding an ARCA-specific extension key (e.g. ar-arca-start-date) in the GOBL library itself. Alternatively, we could keep using registration.other but store only the date (e.g. "2016-03-01") and have the template render the "Inicio de actividades:" label — though that couples the display logic to an assumption about what other means for AR invoices. Happy to go whichever direction you prefer.

@methodofaction methodofaction merged commit 67d7261 into main Apr 16, 2026
6 checks passed
@methodofaction methodofaction deleted the arca-legend branch April 16, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants