button for membership discussion part reviving membership by fenekku · Pull Request #1353 · inveniosoftware/invenio-communities

fenekku · 2026-02-17T13:55:12Z

I am reviving the feature for a user to be able to request to become part of a community.

The (draft) RFC describing this feature is here: inveniosoftware/rfcs#111

The rotting corpse of the former PR is here: #1175 .

This PR is just the first in a series — I will submit smaller PRs than a 49 files one, but more of them.

This PR covers the part of the feature that shows the "Request membership" button or "Membership discussion" button on the community header ribbon when feature is enabled.

feat(mshp-req): default communities to be closed to membership requests
feat(mshp-req): update can_request_membership permission
feat(mshp-req): show button of membership discussion on header if applicable

…licable

fenekku · 2026-02-17T14:08:54Z

+    @property
+    def member_policy_is_open(self):
+        """Return true when member policy is open."""
+        return self.member_policy == MemberPolicyEnum.OPEN.value


so that clients of this code don't need to know about MemberPolicyEnum.Open.value

fenekku · 2026-02-17T14:11:02Z

-        if self._errors:
-            res["errors"] = self._errors
-        return res
+    Kept for legacy reasons and availability in the future. Would be happy


Would honestly be happy to remove CommunityItem in its entirety (we are already in a breaking change and non-adopted version).

To be clear the removed code was removed because completely redundant. The parent class already implements the functionality.

fenekku · 2026-02-17T14:11:45Z


 class ArchivedInvitation(Record, MemberMixin):
-    """An archived invitation record.
+    """An archived invitation or membership request record.


may look into ramifications of changing that name in future PRs.

fenekku · 2026-02-17T14:13:13Z

+  {% if request_id_of_pending_member %}
+    <a href="{{ url_for('invenio_app_rdm_requests.user_dashboard_request_view', request_pid_value=request_id_of_pending_member) }}"
+      class="ui button labeled icon rel-mt-1 theme-secondary">
+      <i class="sign-in icon" aria-hidden="true"></i>
+      {{ _("Membership discussion") }}
+    </a>


To note: this is creating a button for invitation discussion even if membership feature itself is not enabled.

The button should appear only if the membership feature is enabled.
I wonder if we should have a feature flag too, which disables entirely this feature, based on my comment above.

I changed it to only display if the feature was enabled at site + community levels. If those are enabled, that button would show up if there is a membership request or an invitation pending. It's a better UX in my opinion to include invitation because someone can't request to join a community if they have already been invited to it.

fenekku · 2026-02-17T14:18:55Z

+    @blueprint.app_context_processor
+    def processor_for_member_button():


This is so that the community records page also gets the request id without changing its view (and having breakage in between change).

Consequences of having the community's records page (aka detail page) defined in invenio-app-rdm. (case of "polluting" the global processor context for something that could have been scoped)

fenekku · 2026-02-17T14:19:55Z

-            else_value="open",
-            then_=then_,
-            else_=else_,
-        )


Replaced by below. This was unreadable when I returned to it.

fenekku · 2026-02-17T14:24:29Z

-            needs = [CommunityRoleNeed(community_id, role) for role in roles]
-            return needs
-        return []
+        return [CommunityRoleNeed(community_id, r) for r in self.roles(**kwargs) or []]


just making more readable in passing.

fenekku · 2026-02-17T14:33:26Z

-            else_=[SystemProcess()],
-        ),
+        IfCommunityAllowsMembershipRequests(
+            then_=[AuthenticatedUserButNotCommunityMember()], else_=[Disable()]


@ntarocco This used to be Disable() but was set to SystemProcess() in d3daea2 . What was the context for that change? I am setting it to Disable() again because of the explanation above. To add to that explanation: it's both surprising for a superuser to encounter the membership button and other related functionality when the feature is off and surprising for a non-superuser manager of a community to then receive a membership request when their community doesn't allow it (a superuser or systemprocess sending one).

It was done because otherwise no CLI/programmatic script can use it, which they normally act with a system user/process.
I agree with you that superusers will see it and it will be confusing. At the same time, we need to allow a system user/process to perform changes. This is useful when running scripts to update things, for example. It might not be needed in this context.

My change was a bulk update Disable -> SystemProcess.

Ok, this is a case of not needed in this context (programmatic request to join only makes sense if the feature is enabled and scripts can always workaround anyway). I've kept the Disable().

fenekku · 2026-02-17T14:35:11Z

    r = client.get(url_of_request, headers=headers)
    assert 200 == r.status_code
-    assert 'Request to join "My Community"' in r.json["title"]
+    assert community_id == r.json["receiver"]["community"]


just more accurate test (don't really care about the title)

…ture enabled [+] - also optimizes for reduced chance of hitting the DB

fenekku · 2026-03-13T18:15:06Z

Merging as mentioned on Discord. This PR introduces pretty thorough gating of the feature and its impact (no additional DB hit until feature enabled at site and community level and not enabled at community level by default even if feature enabled at site-level: https://github.com/inveniosoftware/invenio-communities/pull/1353/changes#diff-a4058314680fdd8690322e8b12c653c6b24e629311cc22f6caebc6506cbdea5aR19), so it should be good.

ntarocco

Sorry for the extremely late review, added a couple of comments. Please feel free to ignore them if they don't make sense to you.

ntarocco · 2026-03-20T15:10:02Z

+        :param community_id: Description
+        :return: UUID: id of active request associated with user and community
+        """
+        return self.record_cls.get_pending_request_id(identity.id, community_id)


Is it OK not having a permission check here?

Yep no permission here is normal as it's more a service utility function (maybe like: https://github.com/inveniosoftware/invenio-communities/blob/master/invenio_communities/members/services/service.py#L526 ). Mostly didn't want the presentation UI layer to be using something from the data layer directly by passing service layer. Gives us a little buffer and keeps it relatively consistent with what we try to do.

ntarocco · 2026-03-20T15:11:05Z

+        :param record: api.Community
+        """
+        config_enabled = bool(
+            current_app.config.get("COMMUNITIES_ALLOW_MEMBERSHIP_REQUESTS")


Suggested change

current_app.config.get("COMMUNITIES_ALLOW_MEMBERSHIP_REQUESTS")

current_app.config["COMMUNITIES_ALLOW_MEMBERSHIP_REQUESTS"]

👍 it's true that it's in the config.py anyway so it will be present. I can switch that in next PRs (if I don't forget!)

fenekku · 2026-03-20T16:28:31Z

Thanks for taking a look @ntarocco ! There are 2 other PRs out covering the requester side (#1358 + inveniosoftware/invenio-app-rdm#3364) and I will be submitting another to cover the backend of the reviewer side soon.

fenekku added 3 commits February 13, 2026 10:50

feat(mshp-req): default communities to be closed to membership requests

7676b0b

feat(mshp-req): update can_request_membership permission

7bf88a6

feat(mshp-req): show button of membership discussion on header if app…

3e0edf8

…licable

fenekku commented Feb 17, 2026

View reviewed changes

fenekku added this to v14 Feb 17, 2026

fenekku moved this to 👀 In review in v14 Feb 17, 2026

feat(mshp-req): only show membership request/discussion button if fea…

6584f15

…ture enabled [+] - also optimizes for reduced chance of hitting the DB

fenekku requested a review from ntarocco March 4, 2026 16:23

fenekku mentioned this pull request Mar 11, 2026

request membership requester side #1358

Merged

fenekku merged commit a3f67a0 into inveniosoftware:master Mar 13, 2026
4 checks passed

github-project-automation Bot moved this from 👀 In review to To release 🤖 in v14 Mar 13, 2026

fenekku deleted the button_for_membership_discussion_part_reviving_membership branch March 13, 2026 18:15

ntarocco reviewed Mar 20, 2026

View reviewed changes

		@blueprint.app_context_processor
		def processor_for_member_button():

	current_app.config.get("COMMUNITIES_ALLOW_MEMBERSHIP_REQUESTS")
	current_app.config["COMMUNITIES_ALLOW_MEMBERSHIP_REQUESTS"]

Conversation

fenekku commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fenekku Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fenekku commented Mar 13, 2026

Uh oh!

Uh oh!

ntarocco left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fenekku commented Mar 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fenekku commented Feb 17, 2026 •

edited

Loading

fenekku Feb 17, 2026 •

edited

Loading