Skip to content

Enabling invenio-cli services setup inside k8s#411

Merged
fenekku merged 2 commits into
inveniosoftware:masterfrom
oarepo:contribution-noop-services
May 6, 2026
Merged

Enabling invenio-cli services setup inside k8s#411
fenekku merged 2 commits into
inveniosoftware:masterfrom
oarepo:contribution-noop-services

Conversation

@mesemus
Copy link
Copy Markdown
Contributor

@mesemus mesemus commented Mar 23, 2026

Description

invenio-cli services setup currently can not be used in k8s, as it will try to instantiate a docker client even if --no-services is passed and the instantiation will fail. This happens inside the DockerHelper constructor where self.docker_client = docker.from_env() is called.

This PR fixes this issue by adding a NoOp implementation of DockerHelper that is used if --no-services are specified.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@mesemus mesemus force-pushed the contribution-noop-services branch from 8da3611 to 4228b9a Compare March 23, 2026 08:02
@mesemus mesemus added this to v14 Mar 23, 2026
@mesemus mesemus moved this to Triage in v14 Mar 23, 2026
* Inside k8s, services setup could not be used
  because docker client is always initialized
  and it fails if docker is not accessible
* Introduced no-op implementation for this
  usecase
@mesemus mesemus force-pushed the contribution-noop-services branch from 4228b9a to 939a14f Compare March 23, 2026 08:25
Comment thread invenio_cli/cli/services.py Outdated
Copy link
Copy Markdown
Contributor

@fenekku fenekku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merging.

@fenekku fenekku merged commit e1eed02 into inveniosoftware:master May 6, 2026
3 checks passed
@github-project-automation github-project-automation Bot moved this from Triage to To release 🤖 in v14 May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To release 🤖

Development

Successfully merging this pull request may close these issues.

3 participants