Fix core-service healthcheck port and add health verification#1394
Merged
barroco merged 1 commit intointeruss:masterfrom Mar 16, 2026
Merged
Conversation
…scripts The docker-compose healthcheck for the core service was hitting port 80 instead of 8082 where the service actually listens, causing the container to always report as unhealthy. Additionally, probe_locally.sh and qualify_locally.sh only checked that containers were running, not that they were healthy. This meant the broken healthcheck was never caught by CI. Both scripts now wait for containers to report healthy before proceeding. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
|
the-glu
approved these changes
Mar 16, 2026
Contributor
the-glu
left a comment
the-glu
left a comment
There was a problem hiding this comment.
Tested locally and working, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
local-dss-core-servicehitshttp://localhost/healthy(port 80) but the core service listens on port 8082, so the healthcheck never passes. This was not previously visible because nothing in the test pipeline checks container health status.probe_locally.shandqualify_locally.shverified that containers were in therunningstate but did not check whether Docker's healthcheck had passed, so the broken healthcheck was not caught by CIhealthybefore proceeding, ensuring healthcheck misconfigurations are caught going forwardTest plan
http://localhost/healthy) fails inside the container (port 80 not listening)http://localhost:8082/healthy) succeeds inside the container(healthy)make probe-locallyandmake qualify-locally🤖 Generated with Claude Code