[monitoring] Add telemetry in router #1391
Merged
mickmis merged 1 commit intointeruss:masterfrom Mar 19, 2026
Merged
Conversation
This was referenced Mar 11, 2026
mickmis
reviewed
Mar 11, 2026
the-glu
force-pushed
the
openapi_add_telemetry
branch
from
dd31308 to
564b24a
Compare
mickmis
approved these changes
Mar 18, 2026
Contributor
mickmis
left a comment
mickmis
left a comment
There was a problem hiding this comment.
LGTM modulo adding clarifying comments.
the-glu
force-pushed
the
openapi_add_telemetry
branch
from
564b24a to
7f4185b
Compare
the-glu
force-pushed
the
openapi_add_telemetry
branch
from
7f4185b to
0d358a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add telemetry directly in router, providing clean tracenames.
Follow #1390 and #1365
Example server tested with
./run_example.shand still working as expected.Name has been removed from default handler, meaning unknown route or
/healthywill just be named 'http', but that probably ok.Router set parent trace name to the path + start a span for actual processing.
Example traces: