Feat: Added CLI flags to start, stop, restart and check status of productions #7
Feat: Added CLI flags to start, stop, restart and check status of productions #7gabriel-ing wants to merge 4 commits intointersystems:mainfrom
Conversation
|
Hi @gabriel-ing. Thank you for this PR! Unfortunately, we’re going to decline it because we already have a fix for issue #5. We’re still discussing the design internally and plan to release the fix soon. In general, we don’t accept PRs that add new features or enhancements unless they have been discussed and approved beforehand. This is outlined in our contributing guidelines: https://github.com/intersystems/pyprod?tab=contributing-ov-file#enhancements Thanks again for taking the time to contribute! |
|
Hi Geet, no worries at all! I suspected that might be the case. One small piece of feedback: having the ability to restart a production from the command line would make a big difference to the developer experience, and it can be implemented fairly simply (as a wrapper around I completely understand that other parts of #5 are more involved and may need more design discussion, but I thought this smaller CLI piece might be worth considering independently. |
Adds new CLI flags to manage productions in intersystem_pyprod:
--start PRODUCTION- start a named production--stop- stop the current production-r,--restart- restart the current production--status- Checks status of production (Running, Stopped, Troubled, Suspended)Additional options:
--timeout VALUE- specify a timeout (integer) for stop/restart operations--force- force stop or restartAlso includes integration tests following existing test conventions.
Contributes towards (but doesn't completely cover) issue #5
Feel free to suggest changes or decline.