Skip to content

Video metadata#38

Open
openAccess wants to merge 8 commits into
internetarchive:v0.4from
openAccess:video-metadata
Open

Video metadata#38
openAccess wants to merge 8 commits into
internetarchive:v0.4from
openAccess:video-metadata

Conversation

@openAccess
Copy link
Copy Markdown

Removed video metadata as option. Will now process automatically.

Comment thread README.md Outdated
to index all WARC records in the file
--screenshot-mode Special Wayback Machine mode for handling WARCs
containing screenshots
--video-mode Special Wayback Machine mode for handling WARCs containing video
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe --video-mode option is now gone. this line should be removed?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought I did - agreed it should be removed.

Comment thread cdx_writer/dispatcher.py Outdated
def dispatch_warcinfo(self, record, env):
return WarcinfoHandler

def dispatch_metadata(self, record, env):
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to repeat this in this class? AllDispatcher is extending DefaultDispatcher.

Comment thread cdx_writer/dispatcher.py Outdated
def dispatch_metadata(self, record, env):
content_type = record.content_type

if content_type and content_type.startswith('application/json;generator-youtube-dl'):
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mimetype is application/json;generator=youtube-dl?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am open to making anything you want. I thought it captured what we needed. Suppose we save some other type of metadata from something not youtube-dl. We could then change the identifier to "generator-different-app" making it easily identifiable for parsing. But that is my assumption with knowing all the details of the playback code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants