Skip to content

reorganize tests; bump coverage check to 0.3.1#4

Merged
mcharytoniuk merged 2 commits into
mainfrom
unit-tests
May 22, 2026
Merged

reorganize tests; bump coverage check to 0.3.1#4
mcharytoniuk merged 2 commits into
mainfrom
unit-tests

Conversation

@mcharytoniuk
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reorganizes a subset of Rust tests by moving them from trzcina/tests integration tests into #[cfg(test)] unit-test modules co-located with the relevant source files, and updates the JavaScript dev dependency used for Rust coverage checking.

Changes:

  • Moved ServiceShutdownOptions tests from integration tests into trzcina/src/service_shutdown_options.rs as unit tests.
  • Moved ServiceShutdownError Display-formatting tests from integration tests into trzcina/src/service_shutdown_error.rs as unit tests.
  • Bumped @intentee/rust-coverage-check from 0.2.0 to 0.3.1.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
trzcina/tests/service_shutdown_options_default_uses_ten_second_deadlines.rs Removed (test relocated into service_shutdown_options.rs unit tests).
trzcina/tests/service_shutdown_options_can_be_cloned.rs Removed (test relocated into service_shutdown_options.rs unit tests).
trzcina/tests/service_shutdown_error_display_propagates_outcome_writer_error.rs Removed (test relocated into service_shutdown_error.rs unit tests).
trzcina/tests/service_shutdown_error_display_propagates_header_writer_error.rs Removed (test relocated into service_shutdown_error.rs unit tests).
trzcina/tests/service_shutdown_error_display_formats_all_failure_variants.rs Removed (test relocated into service_shutdown_error.rs unit tests).
trzcina/src/service_shutdown_options.rs Added #[cfg(test)] unit tests for defaults and cloning.
trzcina/src/service_shutdown_error.rs Added #[cfg(test)] unit tests for Display formatting and writer error propagation.
package.json Bumped @intentee/rust-coverage-check to 0.3.1.
package-lock.json Updated lockfile to reflect @intentee/rust-coverage-check@0.3.1.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread trzcina/src/service_shutdown_error.rs
@mcharytoniuk mcharytoniuk merged commit d813f86 into main May 22, 2026
6 checks passed
@mcharytoniuk mcharytoniuk deleted the unit-tests branch May 22, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants