reorganize tests; bump coverage check to 0.3.1#4
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR reorganizes a subset of Rust tests by moving them from trzcina/tests integration tests into #[cfg(test)] unit-test modules co-located with the relevant source files, and updates the JavaScript dev dependency used for Rust coverage checking.
Changes:
- Moved
ServiceShutdownOptionstests from integration tests intotrzcina/src/service_shutdown_options.rsas unit tests. - Moved
ServiceShutdownErrorDisplay-formatting tests from integration tests intotrzcina/src/service_shutdown_error.rsas unit tests. - Bumped
@intentee/rust-coverage-checkfrom0.2.0to0.3.1.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| trzcina/tests/service_shutdown_options_default_uses_ten_second_deadlines.rs | Removed (test relocated into service_shutdown_options.rs unit tests). |
| trzcina/tests/service_shutdown_options_can_be_cloned.rs | Removed (test relocated into service_shutdown_options.rs unit tests). |
| trzcina/tests/service_shutdown_error_display_propagates_outcome_writer_error.rs | Removed (test relocated into service_shutdown_error.rs unit tests). |
| trzcina/tests/service_shutdown_error_display_propagates_header_writer_error.rs | Removed (test relocated into service_shutdown_error.rs unit tests). |
| trzcina/tests/service_shutdown_error_display_formats_all_failure_variants.rs | Removed (test relocated into service_shutdown_error.rs unit tests). |
| trzcina/src/service_shutdown_options.rs | Added #[cfg(test)] unit tests for defaults and cloning. |
| trzcina/src/service_shutdown_error.rs | Added #[cfg(test)] unit tests for Display formatting and writer error propagation. |
| package.json | Bumped @intentee/rust-coverage-check to 0.3.1. |
| package-lock.json | Updated lockfile to reflect @intentee/rust-coverage-check@0.3.1. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.