handle windows-style paths in llvm-cov reports#1
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds Windows-style path handling for crate detection in llvm-cov JSON reports so coverage entries can be grouped by crate when report paths use backslashes.
Changes:
- Switches workspace-relative crate extraction to
node:path’swin32helpers. - Adds tests for Windows-style paths and Windows llvm-cov fixture parsing.
- Adds a Windows-style llvm-cov JSON fixture.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/workspace-relative-crate.mjs |
Updates path resolution and crate extraction for Windows-style separators. |
tests/workspace-relative-crate.test.mjs |
Adds a unit test for Windows-style workspace paths. |
tests/parse-llvm-cov-json.test.mjs |
Adds parsing coverage for a Windows-style llvm-cov report. |
tests/fixtures/windows-llvm-cov.json |
Provides Windows-path llvm-cov fixture data. |
package.json |
Adjusts the bin entry path formatting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.