Skip to content

handle windows-style paths in llvm-cov reports#1

Merged
mcharytoniuk merged 7 commits into
mainfrom
windows-paths
May 19, 2026
Merged

handle windows-style paths in llvm-cov reports#1
mcharytoniuk merged 7 commits into
mainfrom
windows-paths

Conversation

@mcharytoniuk
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds Windows-style path handling for crate detection in llvm-cov JSON reports so coverage entries can be grouped by crate when report paths use backslashes.

Changes:

  • Switches workspace-relative crate extraction to node:path’s win32 helpers.
  • Adds tests for Windows-style paths and Windows llvm-cov fixture parsing.
  • Adds a Windows-style llvm-cov JSON fixture.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/workspace-relative-crate.mjs Updates path resolution and crate extraction for Windows-style separators.
tests/workspace-relative-crate.test.mjs Adds a unit test for Windows-style workspace paths.
tests/parse-llvm-cov-json.test.mjs Adds parsing coverage for a Windows-style llvm-cov report.
tests/fixtures/windows-llvm-cov.json Provides Windows-path llvm-cov fixture data.
package.json Adjusts the bin entry path formatting.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/workspace-relative-crate.mjs Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

Comment thread src/workspace-relative-crate.mjs Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

Comment thread src/workspace-relative-crate.mjs
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

Comment thread src/workspace-relative-crate.mjs
Comment thread src/workspace-relative-crate.mjs
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

Comment thread src/workspace-relative-crate.mjs
@mcharytoniuk mcharytoniuk merged commit 4d104d0 into main May 19, 2026
4 checks passed
@mcharytoniuk mcharytoniuk deleted the windows-paths branch May 19, 2026 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants