Bump trzcina to 0.3.0#239
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the project to use trzcina v0.3.0, adapting all internal services to the updated Service trait signature by switching run to consume self: Box<Self>. It also refactors reconciliation/arbiter services to work with the new ownership model.
Changes:
- Bump
trzcinadependency from=0.2.1to=0.3.0(and updateCargo.lockaccordingly). - Update all
trzcina::Serviceimplementations toasync fn run(self: Box<Self>, ...). - Refactor reconciliation and llama.cpp arbiter services to avoid borrowing
selfmutably and to work with moved fields.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| paddler/src/balancer/web_admin_panel_service/mod.rs | Adjust Service::run receiver to Box<Self> for trzcina v0.3.0. |
| paddler/src/balancer/statsd_service/mod.rs | Adjust Service::run receiver to Box<Self>. |
| paddler/src/balancer/reconciliation_service.rs | Refactor reconciliation logic to use moved fields + helper fns; update run signature. |
| paddler/src/balancer/management_service/mod.rs | Adjust Service::run receiver to Box<Self>. |
| paddler/src/balancer/inference_service/mod.rs | Adjust Service::run receiver to Box<Self>. |
| paddler/src/balancer/compatibility/openai_service/mod.rs | Adjust Service::run receiver to Box<Self>. |
| paddler/src/agent/reconciliation_service.rs | Refactor reconciliation into helper fns and update run to consume Box<Self>. |
| paddler/src/agent/management_socket_client_service.rs | Adjust Service::run receiver to Box<Self>. |
| paddler/src/agent/llamacpp_arbiter_service.rs | Refactor arbiter service for moved fields; update run signature; update test to call boxed run. |
| Cargo.toml | Bump trzcina to =0.3.0. |
| Cargo.lock | Lockfile update for trzcina 0.3.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…er teardown through async helper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.