Skip to content

Migrate service manager to trzcina + adopt ServiceBundle#238

Merged
mcharytoniuk merged 6 commits into
mainfrom
service-manager-via-trzcina
May 22, 2026
Merged

Migrate service manager to trzcina + adopt ServiceBundle#238
mcharytoniuk merged 6 commits into
mainfrom
service-manager-via-trzcina

Conversation

@mcharytoniuk
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings May 21, 2026 17:51
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates Paddler’s internal service orchestration from the in-repo Service/ServiceManager implementation to the external trzcina crate, and introduces ServiceBundle-based bootstrapping for agent and balancer components.

Changes:

  • Replaced in-crate Service + ServiceManager with trzcina::Service + trzcina::ServiceManager across balancer/agent services and runners.
  • Introduced AgentServiceBundle / BalancerServiceBundle to construct and register groups of services.
  • Standardized shutdown handling by introducing a shared SHUTDOWN_DEADLINE and adding Actix HTTP server shutdown timeouts.

Reviewed changes

Copilot reviewed 27 out of 28 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
paddler/src/service.rs Removed the in-crate Service trait (migration to trzcina).
paddler/src/service_manager.rs Removed the in-crate service manager implementation and its tests.
paddler/src/lib.rs Stopped exporting service and service_manager modules.
paddler/src/balancer/web_admin_panel_service/mod.rs Switched to trzcina::Service; added HTTP server shutdown timeout.
paddler/src/balancer/statsd_service/mod.rs Switched to trzcina::Service.
paddler/src/balancer/reconciliation_service.rs Switched to trzcina::Service.
paddler/src/balancer/management_service/mod.rs Switched to trzcina::Service; added HTTP server shutdown timeout.
paddler/src/balancer/inference_service/mod.rs Switched to trzcina::Service; added HTTP server shutdown timeout.
paddler/src/balancer/compatibility/openai_service/mod.rs Switched to trzcina::Service; added HTTP server shutdown timeout.
paddler/src/agent/reconciliation_service.rs Switched to trzcina::Service.
paddler/src/agent/management_socket_client_service.rs Switched to trzcina::Service; replaced actix_web::rt::spawn with tokio::spawn.
paddler/src/agent/llamacpp_arbiter_service.rs Switched to trzcina::Service.
paddler/Cargo.toml Added trzcina dependency.
paddler_cli/src/main.rs Moved CLI entrypoint to run under an Actix System (block_on) instead of #[tokio::main].
paddler_cli/src/cmd/balancer.rs Replaced runner-based startup with BalancerServiceBundle + trzcina::ServiceManager.
paddler_cli/src/cmd/agent.rs Replaced runner-based startup with AgentServiceBundle + trzcina::ServiceManager.
paddler_cli/Cargo.toml Added trzcina dependency.
paddler_bootstrap/src/shutdown_deadline.rs Added shared shutdown deadline constant.
paddler_bootstrap/src/lib.rs Exported new service bundle modules; removed old bootstrapped handle modules.
paddler_bootstrap/src/balancer_service_bundle.rs Added bundle that constructs and returns balancer services as a ServiceBundle.
paddler_bootstrap/src/balancer_runner.rs Updated runner to register and run the bundle via trzcina::ServiceManager.
paddler_bootstrap/src/agent_service_bundle.rs Added bundle that constructs and returns agent services as a ServiceBundle.
paddler_bootstrap/src/agent_runner.rs Updated runner to register and run the bundle via trzcina::ServiceManager.
paddler_bootstrap/Cargo.toml Added async-trait and trzcina dependencies.
Cargo.toml Added workspace dependency pin for trzcina.
Cargo.lock Locked trzcina and dependency graph updates.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread paddler/src/balancer/management_service/mod.rs
Comment thread paddler/src/balancer/inference_service/mod.rs
Comment thread paddler/src/balancer/compatibility/openai_service/mod.rs
Comment thread paddler/src/balancer/web_admin_panel_service/mod.rs
Comment thread paddler_bootstrap/src/shutdown_deadline.rs Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 26 out of 27 changed files in this pull request and generated 2 comments.

Comment thread paddler_bootstrap/src/balancer_runner.rs
Comment thread paddler_bootstrap/src/agent_runner.rs
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 26 out of 27 changed files in this pull request and generated no new comments.

@mcharytoniuk mcharytoniuk merged commit 15a2a38 into main May 22, 2026
16 checks passed
@mcharytoniuk mcharytoniuk deleted the service-manager-via-trzcina branch May 22, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants