Support for Heterogenous Block Sizes within CsrTop#283
Open
kimmeljo wants to merge 3 commits intointel:mainfrom
Open
Support for Heterogenous Block Sizes within CsrTop#283kimmeljo wants to merge 3 commits intointel:mainfrom
kimmeljo wants to merge 3 commits intointel:mainfrom
Conversation
kimmeljo
requested review from
desmonddak and
mkorbel1
and removed request for
mkorbel1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & Motivation
In some cases, it is desirable within a
CsrTopto have blocks that have different sizes. Currently, there is one universal block size that is applied to every block. This PR aims to relax that restriction.Related Issue(s)
N/A
Testing
Added explicit unit tests to the Csr unit testing covering the case of heterogeneous block sizes within a
CsrTop.Backwards-compatibility
This change is fully backwards compatible because to exercise this new behavior there is a new optional member attribute on
CsrBlockConfig. By default, we fall back on the original behavior of a block size defined inCsrTop.Documentation
Csr documentation will be updated as needed.