Add support for explicit object decls#210
Merged
JonatanWaern merged 1 commit intomainfrom Mar 12, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for explicit object declarations in DML, using the in OBJECT syntax to disambiguate from the existing in each construct. It introduces a new ExplicitObjectDecls provisional, renames the Connection variant to Connect, and refactors the parser to extract dispatch_object_kind and handle the in token disambiguation.
Changes:
- Refactored DML object parsing into
dispatch_object_kind, addingin OBJECTdisambiguation logic for explicit merge declarations - Renamed
DMLObjectContent::ConnectiontoDMLObjectContent::Connectfor consistency with theTokenKind::Connectkeyword - Added
ExplicitObjectDeclsprovisional andexplicit_merge_tokfield toCompositeObjectContent
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/analysis/parsing/structure.rs | Core parsing refactor: extracted dispatch_object_kind, added explicit_merge_parse, parse_ineach_content, new dmlobject_first_token_matcher for in disambiguation |
| src/analysis/structure/objects.rs | Added explictly_merged field to CompositeObject, renamed Connection to Connect |
| src/analysis/parsing/tree.rs | Added as_some_mut helper method on AstObject |
| src/analysis/provisionals.rs | Added ExplicitObjectDecls provisional variant and test |
| CHANGELOG.md | Documented the new feature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>
307f085 to
773f729
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jonatan Waern jonatan.waern@intel.com