Skip to content

Add support for explicit object decls#210

Merged
JonatanWaern merged 1 commit intomainfrom
add-explicit-object-decl
Mar 12, 2026
Merged

Add support for explicit object decls#210
JonatanWaern merged 1 commit intomainfrom
add-explicit-object-decl

Conversation

@JonatanWaern
Copy link
Contributor

Signed-off-by: Jonatan Waern jonatan.waern@intel.com

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for explicit object declarations in DML, using the in OBJECT syntax to disambiguate from the existing in each construct. It introduces a new ExplicitObjectDecls provisional, renames the Connection variant to Connect, and refactors the parser to extract dispatch_object_kind and handle the in token disambiguation.

Changes:

  • Refactored DML object parsing into dispatch_object_kind, adding in OBJECT disambiguation logic for explicit merge declarations
  • Renamed DMLObjectContent::Connection to DMLObjectContent::Connect for consistency with the TokenKind::Connect keyword
  • Added ExplicitObjectDecls provisional and explicit_merge_tok field to CompositeObjectContent

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
src/analysis/parsing/structure.rs Core parsing refactor: extracted dispatch_object_kind, added explicit_merge_parse, parse_ineach_content, new dmlobject_first_token_matcher for in disambiguation
src/analysis/structure/objects.rs Added explictly_merged field to CompositeObject, renamed Connection to Connect
src/analysis/parsing/tree.rs Added as_some_mut helper method on AstObject
src/analysis/provisionals.rs Added ExplicitObjectDecls provisional variant and test
CHANGELOG.md Documented the new feature

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>
@JonatanWaern JonatanWaern force-pushed the add-explicit-object-decl branch from 307f085 to 773f729 Compare March 12, 2026 12:21
@JonatanWaern JonatanWaern requested a review from TSonono March 12, 2026 12:48
Copy link

@TSonono TSonono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JonatanWaern JonatanWaern merged commit 91c2825 into main Mar 12, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants