Skip to content

[regression] fix copy missing tensors for llama4#1579

Merged
xin3he merged 2 commits intomainfrom
xinhe/3-19
Mar 20, 2026
Merged

[regression] fix copy missing tensors for llama4#1579
xin3he merged 2 commits intomainfrom
xinhe/3-19

Conversation

@xin3he
Copy link
Copy Markdown
Contributor

@xin3he xin3he commented Mar 20, 2026

Description

for google/gemma-3-4b-it: language_model.model.*model.language_model.*.
but for llama4, we need keep it.
So this change verifies both.

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Performance improvement
  • Code refactoring
  • Other (please specify):

Related Issues

Fixes or relates to #

Checklist Before Submitting

  • My code has been tested locally.
  • Documentation has been updated as needed.
  • New or updated tests are included where applicable.

Signed-off-by: Xin He <xin3.he@intel.com>
Copilot AI review requested due to automatic review settings March 20, 2026 03:14
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes missing-tensor detection/copy logic to handle tensor-name prefix mismatches (reported as a Llama4 regression), and improves readability/determinism of layer-name summaries in logs.

Changes:

  • Adds tensor-name aliasing so missing detection matches saved tensors even when prefixes differ (e.g., language_model.model.*model.language_model.*).
  • Improves ignored-layer logging by compressing layer names before printing.
  • Makes compress_layer_names() output deterministic by sorting the final parts list.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
auto_round/utils/missing_tensors.py Enhances missing-tensor detection via name aliasing and improves config-update logging output.
auto_round/utils/common.py Sorts compressed layer-name parts to make summaries deterministic.

Comment thread auto_round/utils/missing_tensors.py
Comment thread auto_round/utils/missing_tensors.py
Signed-off-by: Xin He <xin3.he@intel.com>
@xin3he xin3he merged commit 38c7035 into main Mar 20, 2026
29 checks passed
@xin3he xin3he deleted the xinhe/3-19 branch March 20, 2026 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants