Open
Conversation
Signed-off-by: Mengni Wang <mengni.wang@intel.com>
for more information, see https://pre-commit.ci
wenhuach21
reviewed
Mar 3, 2026
wenhuach21
reviewed
Mar 3, 2026
yiliu30
reviewed
Mar 4, 2026
Contributor
yiliu30
left a comment
yiliu30
left a comment
There was a problem hiding this comment.
Overall LGTM, left a few comments.
Contributor
Author
|
RTN:
Tuning:
|
Contributor
Thanks for the data, add mmlu and mmlu pro please |
Signed-off-by: Mengni Wang <mengni.wang@intel.com>
for more information, see https://pre-commit.ci
Contributor
Author
|
ut depends on #1525 |
yiliu30
reviewed
Mar 12, 2026
Contributor
Author
|
I will create another PR to optimize the quant function for rtn/opt_rtn/tuning @wenhuach21 |
Signed-off-by: Mengni Wang <mengni.wang@intel.com>
Signed-off-by: Mengni Wang <mengni.wang@intel.com>
for more information, see https://pre-commit.ci
wenhuach21
reviewed
Mar 13, 2026
wenhuach21
reviewed
Mar 13, 2026
wenhuach21
reviewed
Mar 13, 2026
wenhuach21
reviewed
Mar 13, 2026
wenhuach21
reviewed
Mar 13, 2026
wenhuach21
reviewed
Mar 13, 2026
Signed-off-by: Mengni Wang <mengni.wang@intel.com>
for more information, see https://pre-commit.ci
Signed-off-by: Mengni Wang <mengni.wang@intel.com>
Signed-off-by: Mengni Wang <mengni.wang@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support block-wise fp8 quant
#959
Type of Change