Skip to content

changes to support provisional logs#742

Merged
jyao1 merged 1 commit intointel:mainfrom
mgudaram:provisional_log
Mar 19, 2026
Merged

changes to support provisional logs#742
jyao1 merged 1 commit intointel:mainfrom
mgudaram:provisional_log

Conversation

@mgudaram
Copy link
Contributor

Provisional logs store logs until VMM enables memory logging and copies these logs into the memory area. Provisional logs would be 4KB circular buffer per vCPU.

@mgudaram mgudaram requested a review from jyao1 as a code owner March 11, 2026 20:10
@jyao1
Copy link
Contributor

jyao1 commented Mar 16, 2026

I am OK with this change. May I know what kind of test you have run to ensure the code is correct?

@mgudaram
Copy link
Contributor Author

mgudaram commented Mar 17, 2026

Hi Jiewen,

I have added few unit-test cases in this PR to test the basic feature functionality (new feature also uses the same function entrylog as logging but with different memory area, so all the unit testcases relevant for logging cornercases will verify provisionallog circular buffer as well),
test_provisional_entrylog
test_provisional_and_entrylog_combined

Also, I booted the MigTD (w/o proviosional log vs w/), exposed memory area from VMM and we can now see the logs prior to enablelogarea request with new feature. PFA the image of windbg

w/ provisional logs enabled, earlier boot logs are copied and exposed in shared memory area during enablelogarea
provisionallog_after

w/o provisional logs, only logs after enablelogarea are visible in memory area
provisionallog_before

Thanks,
Meghana

@jyao1 jyao1 merged commit a1da894 into intel:main Mar 19, 2026
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants