feat(credential-requests): Add implementation of the credential requests endpoints#35
Open
Bram Winter (winterworks) wants to merge 13 commits intomainfrom
Open
feat(credential-requests): Add implementation of the credential requests endpoints#35Bram Winter (winterworks) wants to merge 13 commits intomainfrom
Bram Winter (winterworks) wants to merge 13 commits intomainfrom
Conversation
Copilot started reviewing on behalf of
Bram Winter (winterworks)
February 23, 2026 09:05
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Adds first-class support for the Make “credential requests” API surface to the SDK (and exposes it via MCP tools), along with test fixtures and an integration test.
Changes:
- Introduces
CredentialRequestsendpoint client with list/get/create/delete and credential actions (get/decline/delete-remote). - Registers new MCP tools for credential-requests and wires the endpoint into
Make+ MCP tool aggregation. - Adds credential-requests mock fixtures and an integration test.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| test/mocks/credential-requests/list.json | Adds mock payload for listing credential requests (incl. pagination block). |
| test/mocks/credential-requests/get.json | Adds mock payload for fetching a single credential request. |
| test/mocks/credential-requests/get-credential.json | Adds mock payload for fetching a credential by id. |
| test/mocks/credential-requests/delete-remote.json | Adds mock payload for delete-remote credential action response. |
| test/mocks/credential-requests/decline.json | Adds mock payload for decline credential action response. |
| test/mocks/credential-requests/create.json | Adds mock payload for create credential request response. |
| test/credential-requests.integration.test.ts | Adds integration coverage for credential-requests flows. |
| src/mcp.ts | Registers credential-requests MCP tools in MakeMCPTools. |
| src/make.ts | Exposes make.credentialRequests on the SDK client. |
| src/index.ts | Exports credential-requests types for SDK consumers. |
| src/endpoints/credential-requests.ts | Implements the CredentialRequests endpoint client + related types. |
| src/endpoints/credential-requests.mcp.ts | Adds MCP tool definitions for credential-requests operations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Patrik Simek (patriksimek)
requested changes
Feb 26, 2026
src/endpoints/credential-requests.ts
Outdated
| * Delete a credential request by ID | ||
| * @param requestId - The ID of the credential request to delete | ||
| * @param options - Optional parameters | ||
| * @param options.confirmed - When true, also deletes associated credentials (connections and keys) |
There was a problem hiding this comment.
Could we please rename confirmed to something that better reflects what is actually happening? Ideally, this change should apply not only here but also in the API. The term confirmed is already used on the platform for a different purpose - to display a confirmation dialog in the UI - so the current name is misleading.
…tion of associated credentials
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add implementation of the new credential requests endpoints.